Fixed: #4682 - MSSQL: Doesn't support (n CHAR) syntax, but only (n) s…

…yntax.
liquibase · Aug 30, 2023 · 285a987 · 285a987
1 parent d233ed0
commit 285a987
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/liquibase-standard/src/main/java/liquibase/datatype/core/CharType.java b/liquibase-standard/src/main/java/liquibase/datatype/core/CharType.java
@@ -22,7 +22,9 @@ public DatabaseDataType toDatabaseDataType(Database database) {
         if (database instanceof MSSQLDatabase) {
             Object[] parameters = getParameters();
             if (parameters.length > 0) {
-                String param1 = parameters[0].toString();
+                // MSSQL only supports (n) syntax but not (n CHAR) syntax, so we need to remove CHAR.
+                final String param1 = parameters[0].toString().replaceFirst("(?<=\\d+)\\s*(?i)CHAR$", "");
+                parameters[0] =  param1;
                 if (!param1.matches("\\d+") || (new BigInteger(param1).compareTo(BigInteger.valueOf(8000)) > 0)) {
 
                     DatabaseDataType type = new DatabaseDataType(database.escapeDataTypeName("char"), 8000);

diff --git a/liquibase-standard/src/main/java/liquibase/datatype/core/VarcharType.java b/liquibase-standard/src/main/java/liquibase/datatype/core/VarcharType.java
@@ -26,7 +26,9 @@ public DatabaseDataType toDatabaseDataType(Database database) {
         if (database instanceof MSSQLDatabase) {
             Object[] parameters = getParameters();
             if (parameters.length > 0) {
-                String param1 = parameters[0].toString();
+                // MSSQL only supports (n) syntax but not (n CHAR) syntax, so we need to remove CHAR.
+                final String param1 = parameters[0].toString().replaceFirst("(?<=\\d+)\\s*(?i)CHAR$", "");
+                parameters[0] =  param1;
                 if (!param1.matches("\\d+") || (new BigInteger(param1).compareTo(BigInteger.valueOf(8000L)) > 0)) {
 
                     DatabaseDataType type = new DatabaseDataType(database.escapeDataTypeName("varchar"), "MAX");