Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing parenthesis with comma does not work #1103

Closed
robstoll opened this issue Apr 20, 2020 · 3 comments · Fixed by #3426
Closed

mixing parenthesis with comma does not work #1103

robstoll opened this issue Apr 20, 2020 · 3 comments · Fixed by #3426
Assignees
Labels
DBAll DBMariaDB hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs ImpactLow IntegrationMaven Severity4 sprint2022-38 TypeEnhancement

Comments

@robstoll
Copy link

robstoll commented Apr 20, 2020

Environment

Liquibase Version: 3.8.9

Liquibase Integration & Version: maven

Liquibase Extension(s) & Version: none

Database Vendor & Version: mariadb

Operating System Type & Version: ubuntu 19.10

Description

e.g. "(local, cloud) and (test, pre-prod)" fails with

liquibase.exception.UnexpectedLiquibaseException: Cannot parse expression (local
	at liquibase.util.ExpressionMatcher.matches(ExpressionMatcher.java:58)
	at liquibase.ContextExpression.matches(ContextExpression.java:90)
	at liquibase.ContextExpression.matches(ContextExpression.java:82)
	at liquibase.changelog.filter.ContextChangeSetFilter.accepts(ContextChangeSetFilter.java:42)
	at liquibase.changelog.ChangeLogIterator.run(ChangeLogIterator.java:70)
	at liquibase.changelog.DatabaseChangeLog.validate(DatabaseChangeLog.java:281)
	at liquibase.Liquibase.update(Liquibase.java:198)
	at liquibase.Liquibase.update(Liquibase.java:179)
	at liquibase.Liquibase.update(Liquibase.java:175)

Steps To Reproduce

See above

Actual Behavior

See above

Expected/Desired Behavior

should work the same way as:

"(local or cloud) and (test or pre-prod)"

@molivasdat
Copy link
Contributor

Hi @robstoll . Thanks for taking the time to write up this issue. One additional question to help us evaluate this issue, where are you using the mixture of commas and paranthesis? In the contexts, in the labels? Can you share the command you are using to see the error?

@robstoll
Copy link
Author

robstoll commented May 4, 2020

in the yml, for instance:

databaseChangeLog:
  - changeSet:
      id: 1
      context: "(local, cloud) and (test, pre-prod)"

Is this enough or do you require more information?

@molivasdat
Copy link
Contributor

Thanks @robstoll. I think that should be good enough to process further.

@molivasdat molivasdat added ImpactLow RiskMedium Changes that require more testing or that affect many different code paths. Severity4 TypeEnhancement labels May 4, 2020
@molivasdat molivasdat added DBAll DBMariaDB and removed RiskMedium Changes that require more testing or that affect many different code paths. labels May 19, 2020
@molivasdat molivasdat added the hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs label Sep 26, 2020
rozenshteyn added a commit to rozenshteyn/liquibase that referenced this issue Oct 29, 2022
@filipelautert filipelautert self-assigned this Nov 10, 2022
filipelautert added a commit that referenced this issue Nov 18, 2022
Co-authored-by: filipe lautert <flautert@liquibase.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBAll DBMariaDB hacktoberfest a month-long celebration of open-source software and Developers contribute by completing PRs ImpactLow IntegrationMaven Severity4 sprint2022-38 TypeEnhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants