Invalid update SQL generated for HSQL database in InsertOrUpdateGeneratorHsql.java

[devorgpl]

Environment

Liquibase: all branches, verified on 4.2.x
Database Vendor: HSQL

Description

Invalid SQL generated for HSQL database in InsertOrUpdateGeneratorHsql.java

Note: Found when trying to use:

<loadUpdateData tableName="testtable"
                        primaryKey="id_pk"
                        relativeToChangelogFile="true"
                        onlyUpdate="true"
                        file="data.csv">
            <column name="column1" />
            <column name="column2" />
        </loadUpdateData>

• no table name in update script
• no where clause in update script
• note: no tests for this file

Steps To Reproduce

package liquibase.sqlgenerator.core

import liquibase.database.core.HsqlDatabase
import liquibase.statement.core.InsertOrUpdateStatement
import spock.lang.Specification

class InsertOrUpdateGeneratorHsqlTest extends Specification {

    def 'should get correct update statement'() {
        given:
        def stat = new InsertOrUpdateStatement(null, null, "testtable", "id_pk", true)
        stat.addColumnValue("column1", "value1")
        stat.addColumnValue("column2", "value2")
        def where = "id_pk = '1'"

        when:
        def result = new InsertOrUpdateGeneratorHsql().getUpdateStatement(stat, new HsqlDatabase(), where, null)

        then:
        result == "UPDATE testtable SET column1 = 'value1',column2 = 'value2' where id_pk = '1'"
    }
}

Actual Behavior && Desired Behavior

result == "UPDATE testtable SET column1 = 'value1',column2 = 'value2' where id_pk = '1'"
|      |
|      false
|      28 differences (63% similarity)
|      UPDATE (----------)SET column1 = 'value1',column2 = 'value2'(------------------)
|      UPDATE (testtable )SET column1 = 'value1',column2 = 'value2'( where id_pk = '1')
UPDATE SET column1 = 'value1',column2 = 'value2'

[molivasdat]

Thanks @devorgpl for writing up this issue and adding a PR to fix it. We will add this to the list of issues and PRs to process.