Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1562 invalid update sql generated for hsql #1563

Merged
merged 1 commit into from Jul 28, 2021

Conversation

devorgpl
Copy link
Contributor

@devorgpl devorgpl commented Nov 27, 2020


name: Pull Request
about: #1562 fixes invalid update sql generated fof hsql
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version: all

Liquibase Integration & Version: all

Liquibase Extension(s) & Version:

Database Vendor & Version: hsql

Operating System Type & Version: all

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

add table name and where clause to generated sql

Steps To Reproduce

Actual Behavior

Expected/Desired Behavior

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel


Dev Handoff Notes (Internal Use)

Links

Testing

Dev Verification

(did not save output from the time)

┆Issue is synchronized with this Jira Story by Unito

@molivasdat
Copy link
Contributor

Hi @devorgpl
Thanks for fixing this.
And thanks for your pull request and additional unit test!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest:

The PR will be prioritized according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

@molivasdat molivasdat added DBHSQLDB IntegrationAny RiskMedium Changes that require more testing or that affect many different code paths. Severity3 TypeBug labels Dec 4, 2020
@molivasdat molivasdat added this to To Do in Conditioning++ Jun 4, 2021
@nvoxland nvoxland changed the base branch from 4.2.x to 4.4.x June 7, 2021 21:04
@nvoxland nvoxland moved this from To Do to Code Review in Conditioning++ Jun 7, 2021
@nvoxland nvoxland requested a review from suryaaki2 June 7, 2021 21:06
@suryaaki2 suryaaki2 moved this from Code Review to Ready for Handoff (In JIRA) in Conditioning++ Jun 9, 2021
@liquibase liquibase deleted a comment from codecov bot Jul 15, 2021
@nvoxland nvoxland merged commit 2cc1cae into liquibase:4.4.x Jul 28, 2021
Conditioning++ automation moved this from Ready for Handoff (In JIRA) to Done Jul 28, 2021
@nvoxland nvoxland added this to the v4.4.3 milestone Jul 28, 2021
@nvoxland nvoxland removed this from Done in Conditioning++ Aug 6, 2021
devorgpl added a commit to devorgpl/liquibase that referenced this pull request Jan 16, 2022
reverted changes from PR liquibase#1563 so now it covers both onlyUpdate options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBHSQLDB IntegrationAny RiskMedium Changes that require more testing or that affect many different code paths. Severity3 SyncTicket TypeBug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid update SQL generated for HSQL database in InsertOrUpdateGeneratorHsql.java
4 participants