since refacoring of ClassLoaderResourceAccessor in 4..0.0-beta2, searchPath "classpath*:" is not handled anymore correctly

[chadoc]

Environment

Liquibase Version: 4.2.2

Liquibase Integration & Version: spring-boot 2.3.7.RELEASE

Liquibase Extension(s) & Version: -

Database Vendor & Version: Postgres (but doesn't matter)

Operating System Type & Version: Linux mint (but doesn't matter)

Description

includeAll in a spring-boot project with a searchPath containing a "classpath*:" doesn't find anything.

Steps To Reproduce

Define an "includeAll" task in a spring boot project with a searchPath set to "classpath*:db/changelog" and changelog files available on the searchPath failed because not found
`

• includeAll:
  path: classpath*:db/changelog
  `

Actual Behavior

Doesn't find changelogs

Expected/Desired Behavior

Should find changelog to include

Screenshots (if appropriate)

Additional Context

Problem comes from SpringResourceAccessor.finalizeSearchPath method which expect to always have "classpath:classpath:" and in that case, path is "classpath:classpath*:" so not replaced.

liquibase/liquibase-core/src/main/java/liquibase/integration/spring/SpringResourceAccessor.java

Line 157 in aae1f01

.replace("classpath:classpath:", "classpath:");

[chadoc]

After having tested different version, it looks the issue was introduced by the refactoring of ClassLoaderResourceAccessor already in 4.0.0-beta2:

liquibase/liquibase-core/src/main/java/liquibase/resource/ClassLoaderResourceAccessor.java

Line 219 in bfabfdf

protected SortedSet<String> listFromClassLoader(String path, boolean recursive, boolean includeFiles, boolean includeDirectories) {

[molivasdat]

Hi @chadoc Thank you for bringing this to our attention. Since you have identified the code that was changed, if you have a suggested fix, you can create a PR and reference this issue.

[oleksanderkorn]

I have similar issue. I am using Spring Boot and Liquibase. And I have defined changelog file as following:

databaseChangeLog:
  - includeAll:
      path: db/changelog/0.0.1

When I use liquibase-core version 4.0.0 it works as expected, and changelog files inside db/changelog/0.0.1 are found and applied correctly:

When I only change liquibase version to 4.2.2 the resolved path is now absolute and starts with file: and changeLogStream is null:

SpringResourceAccessor has been rewritten from simple one:

    public class SpringResourceAccessor extends ClassLoaderResourceAccessor {
		public SpringResourceAccessor() {
			super(Thread.currentThread().getContextClassLoader());
		}
	}

Now it is a separate implementation and resolves files to absolute path format file://ABSOLUTE_PATH_TO_FILE which leads to an empty stream at the end.

It works if I use include instead of includeAll, but I would need to include every single file in this case:

databaseChangeLog:
  - include:
      file: db/changelog/0.0.1/MAIN_SCHEMA-changelog.yaml

And in this case file oath is not absolute but relative:

[dekar91]

Same as @oleksanderkorn. Liqubase 4.0.0 works fine, but 4.2.2 creates an ampty stream.
OpenJdk 15, Windows 10.

[tecaz]

Similar setup to @oleksanderkorn (includeAll + path + relativeToChangelogFile), can confirm 4.1.0 is the last version to work as expected, 4.1.1 and the 4.2.x branch all end up in "File was not found in Spring resources" errors.

[nvoxland]

That should have continued to work, I'll try to replicate it and debug it to see what is going on.

[nvoxland]

PR #1665 should fix this.

[sync-by-unito]

➤ Wesley Willard commented:

Looks good

[sync-by-unito]

➤ Nargiz Huss commented:

Liquibase Version: 4.2.2
Liquibase Integration & Version: spring-boot 2.3.7.RELEASE

I was able to replicate the issue using xml file.
includeAll:
path: classpath*:db/changelog and path: classpath:db/changelog

Fix works in 4.3.0-LB-714-SNAPSHOT
For negative testing in my master changelog file I've added an emptyFolder directory that doesn't include anything and it failed. Works as expected.

[nikomiranda]

Still not working on 4.3.1.

SpringResourceAccessor:168 replaces the classpath*: then spring is not searching on all jars.

    protected String finalizeSearchPath(String searchPath) {
        searchPath = "classpath:"+searchPath;
        searchPath = searchPath
                .replaceAll("classpath\\*:", "classpath:")     // <----- LINE 168 
                .replace("\\", "/")
                .replaceAll("//+", "/")
                .replace("classpath:classpath:", "classpath:");

        return searchPath;
    }