Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved SpringResourceAccessor #1665

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Improved SpringResourceAccessor #1665

merged 1 commit into from
Feb 11, 2021

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Feb 3, 2021

  • Support classpath*:
  • Correctly find classes in directories and jar files

Fixes #1657
Fixes #1595

- Support classpath*:
- Correctly find classes in directories and jar files

LB-1157
LB-714
LB-1060
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1665 (ae62640) into 4.3.x (59520d7) will increase coverage by 0.00%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##              4.3.x    #1665   +/-   ##
=========================================
  Coverage     49.30%   49.31%           
- Complexity     7871     7872    +1     
=========================================
  Files           761      761           
  Lines         37361    37371   +10     
  Branches       6756     6759    +3     
=========================================
+ Hits          18422    18429    +7     
- Misses        16478    16480    +2     
- Partials       2461     2462    +1     
Impacted Files Coverage Δ Complexity Δ
...ase/integration/spring/SpringResourceAccessor.java 70.00% <63.63%> (-1.67%) 17.00 <0.00> (+1.00) ⬇️
...iquibase/resource/ClassLoaderResourceAccessor.java 83.96% <100.00%> (ø) 33.00 <0.00> (ø)
...e/src/main/java/liquibase/util/DependencyUtil.java 92.10% <0.00%> (+0.87%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59520d7...ae62640. Read the comment docs.

@famod
Copy link
Contributor

famod commented Feb 4, 2021

I don't think this change will fix #1436 (for Quarkus) since that problem seems to be located somewhere else: https://github.com/liquibase/liquibase/blob/v4.2.2/liquibase-core/src/main/java/liquibase/resource/ClassLoaderResourceAccessor.java#L236

Copy link
Contributor

@wwillard7800 wwillard7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@famod
Copy link
Contributor

famod commented Feb 9, 2021

@wwillard7800 have you seen my comment? WDYT? Thanks!

@nvoxland
Copy link
Contributor Author

nvoxland commented Feb 9, 2021

@famod you are right. This doesn't address your issue. I hadn't looked closely enough at the error messages when I marked this as fixing yours. I'll comment more on your ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBAll IntegrationMaven IntegrationSpringboot RiskMedium Changes that require more testing or that affect many different code paths. Severity2 TypeBug
Projects
None yet
4 participants