-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved SpringResourceAccessor #1665
Conversation
- Support classpath*: - Correctly find classes in directories and jar files LB-1157 LB-714 LB-1060
Codecov Report
@@ Coverage Diff @@
## 4.3.x #1665 +/- ##
=========================================
Coverage 49.30% 49.31%
- Complexity 7871 7872 +1
=========================================
Files 761 761
Lines 37361 37371 +10
Branches 6756 6759 +3
=========================================
+ Hits 18422 18429 +7
- Misses 16478 16480 +2
- Partials 2461 2462 +1
Continue to review full report at Codecov.
|
I don't think this change will fix #1436 (for Quarkus) since that problem seems to be located somewhere else: https://github.com/liquibase/liquibase/blob/v4.2.2/liquibase-core/src/main/java/liquibase/resource/ClassLoaderResourceAccessor.java#L236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@wwillard7800 have you seen my comment? WDYT? Thanks! |
@famod you are right. This doesn't address your issue. I hadn't looked closely enough at the error messages when I marked this as fixing yours. I'll comment more on your ticket. |
Fixes #1657
Fixes #1595