Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquibase.properties not read from classpath #2121

Closed
liefke opened this issue Sep 28, 2021 · 2 comments · Fixed by #2122
Closed

liquibase.properties not read from classpath #2121

liefke opened this issue Sep 28, 2021 · 2 comments · Fixed by #2122
Assignees
Milestone

Comments

@liefke
Copy link
Contributor

liefke commented Sep 28, 2021

Environment

Liquibase Version: 4.5.0
Liquibase Integration & Version: CLI

Description

If I include a liquibase.properties in the classpath, that file is not read when starting Liquibase from the command line.

Steps To Reproduce

  • Create a liquibase.properties file with the required configuration options, especially changeLogFile and url.
  • Package that file into a liquibase-configuration.jar
  • Call liquibase with that liquibase-configuration.jar on the classpath (e.g. put it in the lib folder)

Actual Behavior

Liquibase is complaining about the missing required options.

Expected/Desired Behavior

Liquibase runs with the provided configuration options.

@molivasdat
Copy link
Contributor

Hi @liefke Thanks for creating this issue. We will add this to the list of issues that we are processing. And thanks for creating the PR. Does the use path instead of absolutePath break other scenarios of using Liquibase that are not in the classpath?

@liefke
Copy link
Contributor Author

liefke commented Sep 29, 2021

No, this won't break anything, as I changed only parseDefaultPropertyFileFromResource - which, as I explained, didn't work anyway, while the working scenarios are using parseDefaultPropertyFileFromFile, which I didn't change.

@kataggart kataggart added this to To Do in Conditioning++ via automation Dec 27, 2021
@kataggart kataggart moved this from To Do to In discussion in Conditioning++ Dec 27, 2021
@kataggart kataggart moved this from In discussion to To Do in Conditioning++ Jan 3, 2022
Conditioning++ automation moved this from To Do to Done Feb 14, 2022
@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants