Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate updates to MANIFEST.MF in 4.8.0 release. #2511

Closed
kataggart opened this issue Feb 9, 2022 · 1 comment
Closed

Validate updates to MANIFEST.MF in 4.8.0 release. #2511

kataggart opened this issue Feb 9, 2022 · 1 comment
Assignees
Milestone

Comments

@kataggart
Copy link
Contributor

kataggart commented Feb 9, 2022

The PR to bump manifest versions for OSGI could not be tested prior to merge. This is due to the fact that the changes to the MANIFEST.MF occur only during an official release draft or official release build. This ticket is to ensure Liquibase Internal QA validates the version updates.

@XDelphiGrl XDelphiGrl changed the title Check OSGI in draft release Validate updates to MANIFEST.MF in 4.8.0 release. Feb 9, 2022
@XDelphiGrl
Copy link
Contributor

Our change in build systems and philosophy resulted in the unintentional mis-versioning in the MANIFEST.MF. This fix addresses that mis-versioning. @nvoxland added a script that validates there are no 0-SNAPSHOT or 0.0.0-SNAPSHOT versions in the MANIFEST.MF. This will run at the end of release (internally by Liquibase engineering).


Verify there are no references to 0-SNAPSHOT in MANIFEST.MF PASS
Verify there are no references to 0.0.0-SNAPSHOT in MANIFEST.MF PASS
Verify Bundle-Version in MANIFEST.MF is 4.8.0. PASS


Test Environment
liquibase-4.8.0.jar

@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants