-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-3326 Numero sign is a symbol in Russian #1320
Conversation
Numero sign in Russian it's a regular symbol (https://en.wikipedia.org/wiki/Numero_sign). Problem was described here https://liquibase.jira.com/browse/CORE-3326 and actual for lb 4.0 version
Thanks @tolix Here’s what happens next: A member of the Liquibase team will take a look at your contribution and may suggest:
The PR will be prioritized according to our internal development and testing capacity. We’ll let you know when it’s ready to move to the next step or if any changes are needed. |
Hello! When we can get this fix? |
Hello! When we can get this fix? |
I have add this to the list of issues to process. |
…ix-patch-1 # Conflicts: # liquibase-core/src/main/javacc/liquibase/util/grammar/SimpleSqlGrammar.jj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I resolved the conflict and pushed it to the fork
Hello! |
Numero sign in Russian it's a regular symbol (https://en.wikipedia.org/wiki/Numero_sign)). Problem was described here https://liquibase.jira.com/browse/CORE-3326 and actual for lb 4.0 version
name: Pull Request
about: Create a report to help us improve
title: 'CORE-3326 Numero sign is a symbol in Russian'
labels: Status:Discovery
assignees: ''
Environment
Liquibase Version: 4.0 and earlier
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version: any
Database Vendor & Version: any
Operating System Type & Version: any
Pull Request Type
Description
https://liquibase.jira.com/browse/CORE-3326
Fast Track PR Acceptance Checklist:
<
!--- If you're unsure about any of these, just ask us in a comment. We're here to help|width=200,height=183!
-->
Dev Handoff Notes (Internal Use)
Links
Testing
Dev Verification
Code review and ensured existing automated tests pass. Did not add extra unit test since we don't test every character
Test Requirements (Liquibase Internal QA)
Manual Tests
Verify update-sql works correctly when Numero sign is in comment.
liquibase update-sql --changelog-file lb562-changelog.xml --labels comment
Verify update is successful when Numero sign is in comment.
liquibase update --changelog-file lb562-changelog.xml --labels comment
Verify update-sql works correctly when Numero sign is in insert tag.
liquibase update-sql --changelog-file lb562-changelog.xml --labels insert
Verify update is successful when Numero sign is in insert tag.
liquibase update --changelog-file lb562-changelog.xml --labels insert
Verify update-sql works correctly when Numero sign is in sql tag.
liquibase update-sql --changelog-file lb562-changelog.xml --labels sql
Verify update is successful when Numero sign is in sql tag.
liquibase update --changelog-file lb562-changelog.xml --labels sql
Verify update-sql works correctly when Numero sign is in sqlFile tag.
liquibase update-sql --changelog-file lb562-changelog.xml --labels sqlfile
Verify update is successful when Numero sign is in sqlFile tag.
liquibase update --changelog-file lb562-changelog.xml --labels sqlfile
Verify update-sql works correctly when Numero sign is in formatted sql changelog
liquibase update-sql --changelog-file lb562-changelog.sql
Verify update is successful when Numero sign is in formatted sql changelog
liquibase update --changelog-file lb562-changelog.sql
Verify generate-changelog correctly handles Numero sign
liquibase generate-changelog --changelog-file lb562-generated.xml --diff-types tables,columns,data
drop-all command
update
with generated changelogliquibase update --changelog-file lb562-generated.xml
Automated Tests
No new functional tests required for this fix.
┆Issue is synchronized with this Jira Bug by Unito