Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send generated SQL or changeset body to Hub for changeLogSync DAT-5428 #1390

Merged
merged 2 commits into from Sep 14, 2020

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Sep 9, 2020

…DAT-5428


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #1390 into DAT-5252 will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             DAT-5252    #1390      +/-   ##
==============================================
- Coverage       49.01%   49.01%   -0.01%     
+ Complexity       7702     7701       -1     
==============================================
  Files             753      753              
  Lines           36773    36775       +2     
  Branches         6638     6639       +1     
==============================================
  Hits            18025    18025              
- Misses          16365    16367       +2     
  Partials         2383     2383              
Impacted Files Coverage Δ Complexity Δ
.../liquibase/hub/listener/HubChangeExecListener.java 21.93% <0.00%> (-0.29%) 11.00 <0.00> (ø)
...-core/src/main/java/liquibase/util/ObjectUtil.java 37.43% <0.00%> (-0.56%) 35.00% <0.00%> (-1.00%)
...e/src/main/java/liquibase/util/DependencyUtil.java 92.03% <0.00%> (+0.88%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620a703...561f675. Read the comment docs.

@nvoxland nvoxland changed the base branch from DAT-5252 to DAT-4800 September 14, 2020 21:54
@nvoxland nvoxland merged commit d2779bd into DAT-4800 Sep 14, 2020
@nvoxland nvoxland deleted the DAT-5428 branch September 14, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants