Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation table cannot generate field comments. #1400

Closed
wants to merge 1 commit into from

Conversation

nieqiurong
Copy link

@nieqiurong nieqiurong commented Sep 14, 2020


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1400 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1400      +/-   ##
============================================
- Coverage     48.20%   48.19%   -0.01%     
  Complexity     7558     7558              
============================================
  Files           755      755              
  Lines         36456    36457       +1     
  Branches       6645     6645              
============================================
- Hits          17574    17571       -3     
- Misses        16522    16524       +2     
- Partials       2360     2362       +2     
Impacted Files Coverage Δ Complexity Δ
.../java/liquibase/change/core/CreateTableChange.java 68.80% <0.00%> (ø) 44.00 <0.00> (ø)
...liquibase/statement/core/CreateTableStatement.java 64.48% <0.00%> (-0.61%) 32.00 <0.00> (ø)
...e/src/main/java/liquibase/util/DependencyUtil.java 91.22% <0.00%> (-1.76%) 0.00% <0.00%> (ø%)
...-core/src/main/java/liquibase/util/ObjectUtil.java 36.87% <0.00%> (-1.12%) 35.00% <0.00%> (-1.00%)
...re/src/main/java/liquibase/util/ISODateFormat.java 79.16% <0.00%> (+2.08%) 16.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e76ca...b100e3b. Read the comment docs.

@molivasdat
Copy link
Contributor

Thanks @nieqiurong for creating this issue.
Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

@fatso83
Copy link

fatso83 commented Nov 10, 2023

@molivasdat Maybe the team should have some kind of bot to clean up older issues and PR's that have been stagnant for X number of months? With 150 PRs, it's not likely PR's like this is ever getting merged anyhow.

@filipelautert
Copy link
Collaborator

Seems this has been fixed under commit a975362 .
Please reopen the PR and fix the conflicts if you still facing this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexityLocal DBAll ImpactLow RiskMedium Changes that require more testing or that affect many different code paths. Severity3 TypeEnhancement
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants