Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Implementation for Pro DAT-5592 #1463

Closed
wants to merge 2 commits into from
Closed

MySQL Implementation for Pro DAT-5592 #1463

wants to merge 2 commits into from

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Oct 8, 2020


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1463 into 4.2.x will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              4.2.x    #1463      +/-   ##
============================================
- Coverage     49.16%   49.12%   -0.04%     
- Complexity     7768     7949     +181     
============================================
  Files           755      756       +1     
  Lines         36977    38410    +1433     
  Branches       6666     7224     +558     
============================================
+ Hits          18180    18870     +690     
- Misses        16401    17021     +620     
- Partials       2396     2519     +123     
Impacted Files Coverage Δ Complexity Δ
...n/java/liquibase/command/core/SnapshotCommand.java 3.77% <ø> (ø) 2.00 <0.00> (ø)
.../liquibase/snapshot/jvm/ViewSnapshotGenerator.java 12.12% <0.00%> (-0.58%) 2.00 <0.00> (ø)
...main/java/liquibase/datatype/core/TinyIntType.java 30.30% <0.00%> (-3.04%) 5.00% <0.00%> (+1.00%) ⬇️
...main/java/liquibase/datatype/core/DecimalType.java 39.28% <0.00%> (-2.82%) 6.00% <0.00%> (+1.00%) ⬇️
...ain/java/liquibase/datatype/core/SmallIntType.java 32.00% <0.00%> (-2.38%) 7.00% <0.00%> (+1.00%) ⬇️
...in/java/liquibase/datatype/core/MediumIntType.java 31.25% <0.00%> (-2.09%) 5.00% <0.00%> (+1.00%) ⬇️
...java/liquibase/database/core/PostgresDatabase.java 43.66% <0.00%> (-0.63%) 36.00% <0.00%> (ø%)
.../main/java/liquibase/datatype/core/NumberType.java 31.42% <0.00%> (-0.58%) 6.00% <0.00%> (+1.00%) ⬇️
...ase/statement/ExecutablePreparedStatementBase.java 16.96% <0.00%> (-0.18%) 8.00% <0.00%> (ø%)
...in/java/liquibase/database/jvm/HsqlConnection.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b563fb8...6de4437. Read the comment docs.

@nvoxland nvoxland changed the base branch from 4.1.x to 4.2.x October 14, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants