Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with loadUpdateData GH-1489 #1495

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Fix issue with loadUpdateData GH-1489 #1495

merged 2 commits into from
Nov 3, 2020

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Oct 19, 2020


name: Pull Request
about: Create a report to help us improve
title: ''
labels: Status:Discovery
assignees: ''


Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1495 into 3.10.x will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             3.10.x    #1495      +/-   ##
============================================
+ Coverage     48.65%   48.68%   +0.02%     
- Complexity     7478     7484       +6     
============================================
  Files           727      727              
  Lines         35632    35632              
  Branches       6561     6561              
============================================
+ Hits          17336    17346      +10     
+ Misses        15909    15897      -12     
- Partials       2387     2389       +2     
Impacted Files Coverage Δ Complexity Δ
...ain/java/liquibase/change/core/LoadDataChange.java 54.38% <0.00%> (+2.92%) 73.00 <0.00> (+5.00)
...e/src/main/java/liquibase/util/DependencyUtil.java 91.15% <0.00%> (-0.89%) 0.00% <0.00%> (ø%)
...va/liquibase/change/core/LoadUpdateDataChange.java 27.27% <0.00%> (+2.27%) 9.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fc9ce...385eb7d. Read the comment docs.

@molivasdat molivasdat linked an issue Oct 23, 2020 that may be closed by this pull request
@nvoxland nvoxland changed the base branch from 3.10.x to 4.2.x November 3, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadUpdateData broken for clob/text fields in 3.10.3
3 participants