Move banner.txt to new location

[timurt]

---

name: Move banner.txt to new location
about: #1476
title: ''
labels: Status:Discovery
assignees: ''

---

Environment

Liquibase Version: 4.1.2-local-SNAPSHOT

Liquibase Integration & Version: CLI

Liquibase Extension(s) & Version: -

Database Vendor & Version: -

Operating System Type & Version: Mac OS X 10.13.6

Pull Request Type

• Bug fix (non-breaking change which fixes an issue.)
• Enhancement/New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Followed by #1476

Could you please consider an alternative location for this resource? I am working on the Spring Boot project and we use this location for users that wants to use an alternative banner when starting their apps. Arguably, our default isn't great either and we should probably fix it.

Actual Behavior

Actual location of the banner.txt is under src/main/resources folder

Expected/Desired Behavior

New location of the banner.txt is under src/main/resources/liquibase folder

Fast Track PR Acceptance Checklist:

• Build is successful and all new and existing tests pass
• Added Unit Test(s)
• Added Integration Test(s)
• Documentation Updated

[timurt]

I moved banner.txt to liquibase subfolder, another approach was to rename banner.txt to banner-liquibase.txt

Both ways seem legitimate to me, since initial problem will be solved

[timurt]

And could you please add hacktoberfest-accepted to this PR

[codecov]

Codecov Report

Merging #1496 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1496   +/-   ##
=========================================
  Coverage     47.96%   47.96%           
- Complexity     7871     7872    +1     
=========================================
  Files           793      793           
  Lines         38456    38456           
  Branches       6901     6901           
=========================================
+ Hits          18446    18447    +1     
  Misses        17565    17565           
+ Partials       2445     2444    -1     

Impacted Files	Coverage Δ	Complexity Δ
...base/integration/commandline/CommandLineUtils.java	18.33% <100.00%> (ø)	4.00 <0.00> (ø)
...re/src/main/java/liquibase/util/ISODateFormat.java	80.32% <0.00%> (+1.63%)	17.00% <0.00%> (+1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb4926...a7024b7. Read the comment docs.

[nvoxland]

Thanks!
Cherry picked to 4.2.x as well