Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename + Id + Author is not being treated as unique #1622

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jan 6, 2021

ValidatingVisitor.findChangeSet method

Fixes #1603

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1622 (2afa7d5) into 4.3.x (c2caea7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              4.3.x    #1622      +/-   ##
============================================
- Coverage     49.62%   49.61%   -0.01%     
+ Complexity     7880     7878       -2     
============================================
  Files           759      759              
  Lines         37135    37131       -4     
  Branches       6726     6723       -3     
============================================
- Hits          18428    18423       -5     
- Misses        16248    16250       +2     
+ Partials       2459     2458       -1     
Impacted Files Coverage Δ Complexity Δ
...liquibase/changelog/visitor/ValidatingVisitor.java 68.53% <0.00%> (-1.36%) 29.00 <0.00> (-2.00)
...re/src/main/java/liquibase/util/ISODateFormat.java 78.68% <0.00%> (-1.64%) 16.00% <0.00%> (-1.00%)
...e/src/main/java/liquibase/util/DependencyUtil.java 90.35% <0.00%> (-0.88%) 0.00% <0.00%> (ø%)
...-core/src/main/java/liquibase/util/ObjectUtil.java 41.43% <0.00%> (+0.55%) 39.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2caea7...2afa7d5. Read the comment docs.

Copy link
Contributor

@molivasdat molivasdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's doing the same check as before in a different order and in a different way. May switch the order so that path is the last check done in isSameAs because if the other two are not the same, you will not take the normalize path hit everytime.

@molivasdat molivasdat merged commit fa1250e into 4.3.x Jan 13, 2021
This was referenced Feb 10, 2021
@suryaaki2 suryaaki2 deleted the LB-1072 branch July 30, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filename + Id + Author is not being treated as unique in ValidatingVisitor.findChangeSet method
2 participants