-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filename + Id + Author is not being treated as unique #1622
Conversation
…sitor.findChangeSet method LB-1072
Codecov Report
@@ Coverage Diff @@
## 4.3.x #1622 +/- ##
============================================
- Coverage 49.62% 49.61% -0.01%
+ Complexity 7880 7878 -2
============================================
Files 759 759
Lines 37135 37131 -4
Branches 6726 6723 -3
============================================
- Hits 18428 18423 -5
- Misses 16248 16250 +2
+ Partials 2459 2458 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's doing the same check as before in a different order and in a different way. May switch the order so that path is the last check done in isSameAs because if the other two are not the same, you will not take the normalize path hit everytime.
ValidatingVisitor.findChangeSet method
Fixes #1603