Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated LogFactory.getInstance() to smooth upgrade to 4.x #1642

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jan 20, 2021

Fixes #1641

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #1642 (71b3498) into 4.3.x (78675c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              4.3.x    #1642      +/-   ##
============================================
- Coverage     49.59%   49.59%   -0.01%     
- Complexity     7883     7884       +1     
============================================
  Files           759      759              
  Lines         37152    37153       +1     
  Branches       6727     6727              
============================================
  Hits          18426    18426              
  Misses        16270    16270              
- Partials       2456     2457       +1     
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/liquibase/logging/LogFactory.java 20.00% <100.00%> (+20.00%) 1.00 <1.00> (+1.00)
...e/src/main/java/liquibase/util/DependencyUtil.java 91.22% <0.00%> (-0.88%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78675c1...71b3498. Read the comment docs.

Copy link
Contributor

@molivasdat molivasdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@molivasdat molivasdat merged commit b7e50e1 into 4.3.x Jan 20, 2021
@suryaaki2 suryaaki2 deleted the LB-1133 branch July 30, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecated LogFactory.getInstance() to smooth upgrade to 4.x
2 participants