-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LiquibaseConfiguration API #1776
Conversation
# Conflicts: # liquibase-core/src/main/java/liquibase/hub/HubUpdater.java # liquibase-core/src/main/java/liquibase/integration/spring/SpringLiquibase.java # liquibase-core/src/main/java/liquibase/ui/ConsoleUIService.java # liquibase-integration-tests/src/test/groovy/liquibase/hub/StandardHubServiceTest.groovy # liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/AbstractLiquibaseMojo.java
# Conflicts: # liquibase-core/src/main/java/liquibase/command/core/DropAllCommand.java # liquibase-core/src/main/java/liquibase/command/core/RegisterChangeLogCommand.java # liquibase-core/src/main/java/liquibase/integration/commandline/Main.java # liquibase-core/src/main/java/liquibase/integration/servlet/LiquibaseServletListener.java
…atibility LB-1306
@@ -0,0 +1,82 @@ | |||
package liquibase.configuration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good class for a synopsis at the top. Is it the top-level Map for all properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I missed it, I think it would be good to have a listing of the precedence rules somewhere in the JavaDocs.
- Added ConfigurationValueProvider.getPrecedence javadoc LB-1222
…figuration properties LB-1222
# Conflicts: # liquibase-core/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Improve the liquibase.configuration package to support needed upcoming functionality
Fixes #1691