Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LiquibaseConfiguration API #1776

Merged
merged 23 commits into from
Apr 22, 2021
Merged

Refactor LiquibaseConfiguration API #1776

merged 23 commits into from
Apr 22, 2021

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Mar 23, 2021

Improve the liquibase.configuration package to support needed upcoming functionality

Fixes #1691

# Conflicts:
#	liquibase-core/src/main/java/liquibase/hub/HubUpdater.java
#	liquibase-core/src/main/java/liquibase/integration/spring/SpringLiquibase.java
#	liquibase-core/src/main/java/liquibase/ui/ConsoleUIService.java
#	liquibase-integration-tests/src/test/groovy/liquibase/hub/StandardHubServiceTest.groovy
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/AbstractLiquibaseMojo.java
# Conflicts:
#	liquibase-core/src/main/java/liquibase/command/core/DropAllCommand.java
#	liquibase-core/src/main/java/liquibase/command/core/RegisterChangeLogCommand.java
#	liquibase-core/src/main/java/liquibase/integration/commandline/Main.java
#	liquibase-core/src/main/java/liquibase/integration/servlet/LiquibaseServletListener.java
@@ -0,0 +1,82 @@
package liquibase.configuration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good class for a synopsis at the top. Is it the top-level Map for all properties?

Copy link
Contributor

@wwillard7800 wwillard7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I missed it, I think it would be good to have a listing of the precedence rules somewhere in the JavaDocs.

- Added ConfigurationValueProvider.getPrecedence javadoc

LB-1222
# Conflicts:
#	liquibase-core/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
@nvoxland nvoxland merged commit 256675b into master Apr 22, 2021
@nvoxland nvoxland deleted the LB-1222 branch April 22, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LiquibaseConfiguration API
2 participants