[LB-1373] fixed precision for time type for PostgreSQL #1894

KushnirykOleh · 2021-06-08T14:46:59Z

Environment

Liquibase Version: 4.3.5

Liquibase Integration & Version:

Liquibase Extension(s) & Version:

Database Vendor & Version: postgres 9-13

Operating System Type & Version: MacOS Big Sur 11.4

Pull Request Type

closes #1774
https://datical.atlassian.net/browse/LB-1373

Bug fix (non-breaking change which fixes an issue.)
Enhancement/New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Precision in changeSet for Time Datatype was missing for PostreSQL in generated query (and in DB column properties respectfully)

Steps To Reproduce

create xml changelog with next changeset

<changeSet id="1" author="any">
        <createTable tableName="datatypes_test_table">
            <column name="time" type="time"/>
            <column name="timeewtz" type="time with time zone"/>
            <column name="time0" type="time (0)"/>
            <column name="timee0wtz" type="time (0) with time zone"/>
            <column name="time1" type="time (1)"/>
            <column name="time1wtz" type="time (1) with time zone"/>
            <column name="time2" type="time (2)"/>
            <column name="time2wtz" type="time (2) with time zone"/>
            <column name="time3" type="time (3)"/>
            <column name="time3wtz" type="time (3) with time zone"/>
            <column name="time4" type="time (4)"/>
            <column name="time4wtz" type="time (4) with time zone"/>
            <column name="time5" type="time (5)"/>
            <column name="time5wtz" type="time (5) with time zone"/>
            <column name="time6" type="time (6)"/>
            <column name="time6wtz" type="time (6) with time zone"/> 
        </createTable>
    </changeSet>

Run Liquibase updateSQL command to observe SQL generated for changeLog, notice precision for time is missing

CREATE TABLE datatypes_test_table
(
    time      TIME WITHOUT TIME ZONE,
    timeewtz  TIME WITH TIME ZONE,
    time0     TIME WITHOUT TIME ZONE,
    timee0wtz TIME WITH TIME ZONE,
    time1     TIME WITHOUT TIME ZONE,
    time1wtz  TIME WITH TIME ZONE,
    time2     TIME WITHOUT TIME ZONE,
    time2wtz  TIME WITH TIME ZONE,
    time3     TIME WITHOUT TIME ZONE,
    time3wtz  TIME WITH TIME ZONE,
    time4     TIME WITHOUT TIME ZONE,
    time4wtz  TIME WITH TIME ZONE,
    time5     TIME WITHOUT TIME ZONE,
    time5wtz  TIME WITH TIME ZONE,
    time6     TIME WITHOUT TIME ZONE,
    time6wtz  TIME WITH TIME ZONE
)

Actual Behavior

for mentioned changeSet Liquibase generated query like this

CREATE TABLE datatypes_test_table
(
    time      TIME WITHOUT TIME ZONE,
    timeewtz  TIME WITH TIME ZONE,
    time0     TIME WITHOUT TIME ZONE,
    timee0wtz TIME WITH TIME ZONE,
    time1     TIME WITHOUT TIME ZONE,
    time1wtz  TIME WITH TIME ZONE,
    time2     TIME WITHOUT TIME ZONE,
    time2wtz  TIME WITH TIME ZONE,
    time3     TIME WITHOUT TIME ZONE,
    time3wtz  TIME WITH TIME ZONE,
    time4     TIME WITHOUT TIME ZONE,
    time4wtz  TIME WITH TIME ZONE,
    time5     TIME WITHOUT TIME ZONE,
    time5wtz  TIME WITH TIME ZONE,
    time6     TIME WITHOUT TIME ZONE,
    time6wtz  TIME WITH TIME ZONE
)

with missing precision argument

Expected/Desired Behavior

With this fix for mentioned changeSet Liquibase generates query like this

CREATE TABLE datatypes_test_table
(
    time      time WITHOUT TIME ZONE,
    timeewtz  time WITH TIME ZONE,
    time0     time(0) WITHOUT TIME ZONE,
    timee0wtz time(0) WITH TIME ZONE,
    time1     time(1) WITHOUT TIME ZONE,
    time1wtz  time(1) WITH TIME ZONE,
    time2     time(2) WITHOUT TIME ZONE,
    time2wtz  time(2) WITH TIME ZONE,
    time3     time(3) WITHOUT TIME ZONE,
    time3wtz  time(3) WITH TIME ZONE,
    time4     time(4) WITHOUT TIME ZONE,
    time4wtz  time(4) WITH TIME ZONE,
    time5     time(5) WITHOUT TIME ZONE,
    time5wtz  time(5) WITH TIME ZONE,
    time6     time(6) WITHOUT TIME ZONE,
    time6wtz  time(6) WITH TIME ZONE
)

Run changeSet against PostgreSQL DB and check column properties - it also shows precision

Test Requirements (Liquibase Internal QA)

Prior to manual testing:

Verify the Liquibase Funcitonal tests ran and passed as part of the Github Actions build.
Execute the liquibase/liquibase-test-harness test for liquibase-test-harness/src/main/resources/liquibase/harness/change/changelogs/postgresql/datatypes.datetime.xml against:
- Postgres 9
- Postgres 9.5
- Postgres 10
- Postgres 11
- Postgres 12
- Postgres 13

Manual Tests

The manual tests need only be executed against one version of Postgres.

Verify update-sql correctly generates Postgres SQL to create columns of datatype TIMEZONE with varying precision.

liquibase update-sql --changelog-file lb1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3).
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

Verify a successful update of a Postgres database to create a table with TIMEZONE and precision datatype columns.

liquibase update --changelog-file lb1798-changelog.xml

There are no errors during update.
The table is created on the database.
- Columns have the expected precision on the time datatype; ie time(3).
- Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

Verify generate-changelog includes a createTable changeset with TIMEZONE datatype columns.

liquibase generate-changelog --changelog-file gcl-1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3).
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

Automated Tests

No new functional automated tests are required for this ticket.
Test harness test already created.
Dev also added a unit test.

Fast Track PR Acceptance Checklist:

Build is successful and all new and existing tests pass
Added [Unit Test(s)]
Added [Test Harness Test(s)] - Added previously by Robert, test-harness helped to find this bug.

┆Issue is synchronized with this Jira Bug by Unito

molivasdat · 2021-09-16T01:46:53Z

Thanks @KushnirykOleh for creating the fix.

sync-by-unito · 2021-11-17T15:04:51Z

➤ Steven Massaro commented:

Erzsebet Carmean Nathan Voxland Surya Aki This ticket is dev complete. This PR fixes the issue and I’ve verified it. This is ready for QA sizing.

sync-by-unito · 2021-11-19T21:24:09Z

➤ Erzsebet Carmean commented:

Liquibase Core: master/812/1e5e49/2021-11-18 13:23+0000, Pro: master/146/bfaa6a/2021-11-19T05:05:28Z] #812Build: https://github.com/liquibase/liquibase/actions/runs/1478003258 ( https://github.com/liquibase/liquibase/actions/runs/1478003258 )

Verify the Liquibase Functional tests ran and passed as part of the Github Actions build. PASS
Execute the liquibase/liquibase-test-harness test for liquibase-test-harness ( https://github.com/liquibase/liquibase-test-harness )/src ( https://github.com/liquibase/liquibase-test-harness/tree/main/src )/main ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main )/resources ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources )/liquibase ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources/liquibase )/harness ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources/liquibase/harness )/change ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources/liquibase/harness/change )/changelogs ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources/liquibase/harness/change/changelogs )/postgresql ( https://github.com/liquibase/liquibase-test-harness/tree/main/src/main/resources/liquibase/harness/change/changelogs/postgresql )/datatypes.datetime.xml against:
- Postgres 9 PASS
- Postgres 9.5 PASS
- Postgres 10 PASS
- Postgres 11 PASS
- Postgres 12 PASS
- Postgres 13 PASS
- Postgres 14 PASS

Manual Tests

Verify update-sql correctly generates Postgres SQL to create columns of datatype TIMEZONE with varying precision.

liquibase update-sql --changelog-file lb1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3).
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

Verify a successful update of a Postgres database to create a table with TIMEZONE and precision datatype columns.

liquibase update --changelog-file lb1798-changelog.xml

There are no errors during update.
The table is created on the database.
- Columns have the expected precision on the time datatype; ie time(3).
- Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

Verify generate-changelog includes a createTable changeset with TIMEZONE datatype columns.

liquibase generate-changelog --changelog-file gcl-1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3).
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE

nvoxland · 2022-02-22T23:14:21Z

I fixed up the time precision handling

XDelphiGrl · 2022-02-23T21:48:33Z

This PR addresses issues related to snapshotting precision for Postgres time and time with timezone datatypes.

Execute the liquibase/liquibase-test-harness test for liquibase-test-harness/datatypes.datetime.xml against:
- Postgres 9 PASS
- Postgres 9.5 PASS
- Postgres 10 PASS
- Postgres 11 PASS
- Postgres 12 PASS
- Postgres 13 PASS
- Postgres 14 PASS

Verify update-sql correctly generates Postgres SQL to create columns of datatype TIMEZONE with varying precision. PASS
liquibase update-sql --changelog-file lb1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3). PASS
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE PASS

-- Changeset lb1798-changelog.xml::1::lb1798::Liquibase User
CREATE TABLE public.datatypes_test_table (time time WITHOUT TIME ZONE, timeewtz time WITH TIME ZONE, time0 time(0) WITHOUT TIME ZONE, timee0wtz time(0) WITH TIME ZONE, time1 time(1) WITHOUT TIME ZONE, time1wtz time(1) WITH TIME ZONE, time2 time(2) WITHOUT TIME ZONE, time2wtz time(2) WITH TIME ZONE, time3 time(3) WITHOUT TIME ZONE, time3wtz time(3) WITH TIME ZONE, time4 time(4) WITHOUT TIME ZONE, time4wtz time(4) WITH TIME ZONE, time5 time(5) WITHOUT TIME ZONE, time5wtz time(5) WITH TIME ZONE, time6 time(6) WITHOUT TIME ZONE, time6wtz time(6) WITH TIME ZONE);

Verify a successful update of a Postgres database to create a table with TIMEZONE and precision datatype columns. PASS
liquibase update --changelog-file lb1798-changelog.xml

There are no errors during update. PASS
The table is created on the database. PASS
- Columns have the expected precision on the time datatype; ie time(3). PASS
- Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE PASS

Verify generate-changelog includes a createTable changeset with TIMEZONE datatype columns. PASS
liquibase generate-changelog --changelog-file gcl-1798-changelog.xml

Columns have the expected precision on the time datatype; ie time(3). PASS
Columns have the expected TIMEZONE setting; ie WITHOUT TIME ZONE PASS

<changeSet author="erz (generated)" id="1645634755981-1">
        <createTable tableName="datatypes_test_table">
            <column name="time" type="time(6) WITHOUT TIME ZONE"/>
            <column name="timeewtz" type="time(6) WITH TIME ZONE"/>
            <column name="time0" type="time(0) WITHOUT TIME ZONE"/>
            <column name="timee0wtz" type="time(0) WITH TIME ZONE"/>
            <column name="time1" type="time(1) WITHOUT TIME ZONE"/>
            <column name="time1wtz" type="time(1) WITH TIME ZONE"/>
            <column name="time2" type="time(2) WITHOUT TIME ZONE"/>
            <column name="time2wtz" type="time(2) WITH TIME ZONE"/>
            <column name="time3" type="time(3) WITHOUT TIME ZONE"/>
            <column name="time3wtz" type="time(3) WITH TIME ZONE"/>
            <column name="time4" type="time(4) WITHOUT TIME ZONE"/>
            <column name="time4wtz" type="time(4) WITH TIME ZONE"/>
            <column name="time5" type="time(5) WITHOUT TIME ZONE"/>
            <column name="time5wtz" type="time(5) WITH TIME ZONE"/>
            <column name="time6" type="time(6) WITHOUT TIME ZONE"/>
            <column name="time6wtz" type="time(6) WITH TIME ZONE"/>
        </createTable>
    </changeSet>

Test Environment
Liquibase Core: LB-1373/1611/89a691, Pro: master/645/8151fa
Postgres 12 (for manual testing)
Passing Functional Tests
Test-Harness PR

KushnirykOleh added 2 commits June 1, 2021 16:15

fixed precision for Time datatype

34cf31f

added test, fixed regression

93d47e3

kristyldatical requested review from nvoxland and suryaaki2 June 15, 2021 14:47

nvoxland changed the base branch from master to 4.4.x June 21, 2021 19:14

nvoxland approved these changes Jun 21, 2021

View reviewed changes

molivasdat added BKeyPlatform Key Platform DBPostgres ImpactMedium IntegrationAny Severity3 TypeBug labels Sep 16, 2021

molivasdat added this to To Do in Conditioning++ via automation Oct 29, 2021

mariochampion moved this from To Do to Ready for Handoff (In JIRA) in Conditioning++ Nov 8, 2021

mariochampion added the SyncTicket label Nov 8, 2021

sync-by-unito bot added the StatusConditioning label Nov 8, 2021

suryaaki2 changed the base branch from 4.4.x to master November 12, 2021 19:55

suryaaki2 approved these changes Nov 12, 2021

View reviewed changes

sync-by-unito bot assigned StevenMassaro Nov 17, 2021

Merge branch 'master' into LB-1373

2d83f7d

Merge branch 'master' into LB-1373

3dcd526

sync-by-unito bot added StatusActive and removed StatusConditioning labels Nov 18, 2021

Merge remote-tracking branch 'origin/master' into LB-1373

25f18c2

nvoxland moved this from Ready for Handoff (In JIRA) to In Development in Conditioning++ Dec 7, 2021

kataggart added the daily_review label Feb 7, 2022

kataggart unassigned StevenMassaro Feb 7, 2022

kataggart assigned nvoxland Feb 7, 2022

kataggart removed the daily_review label Feb 8, 2022

nvoxland added 2 commits February 22, 2022 16:43

Merge branch 'master' into LB-1373

f9e9ee2

Fix time datatype precision in postgresql

89a6912

nvoxland removed their assignment Feb 22, 2022

XDelphiGrl mentioned this pull request Feb 23, 2022

PR 1894, LB-1373: Postgres date time precision tests. liquibase/liquibase-test-harness#191

Merged

XDelphiGrl self-assigned this Feb 23, 2022

XDelphiGrl mentioned this pull request Feb 23, 2022

SQL Generator bug. Arguments for TIME and INTERVAL datatypes. #1774

Closed

nvoxland merged commit b6896fc into master Feb 25, 2022

Conditioning++ automation moved this from In Development to Done Feb 25, 2022

nvoxland deleted the LB-1373 branch February 25, 2022 14:33

kataggart modified the milestones: On Deck, NEXT Mar 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LB-1373] fixed precision for time type for PostgreSQL #1894

[LB-1373] fixed precision for time type for PostgreSQL #1894

KushnirykOleh commented Jun 8, 2021 •

edited by sync-by-unito bot

molivasdat commented Sep 16, 2021

sync-by-unito bot commented Nov 17, 2021

sync-by-unito bot commented Nov 19, 2021

nvoxland commented Feb 22, 2022

XDelphiGrl commented Feb 23, 2022

[LB-1373] fixed precision for time type for PostgreSQL #1894

[LB-1373] fixed precision for time type for PostgreSQL #1894

Conversation

KushnirykOleh commented Jun 8, 2021 • edited by sync-by-unito bot

Environment

Pull Request Type

Description

Steps To Reproduce

Actual Behavior

Expected/Desired Behavior

Test Requirements (Liquibase Internal QA)

Fast Track PR Acceptance Checklist:

molivasdat commented Sep 16, 2021

sync-by-unito bot commented Nov 17, 2021

sync-by-unito bot commented Nov 19, 2021

nvoxland commented Feb 22, 2022

XDelphiGrl commented Feb 23, 2022

KushnirykOleh commented Jun 8, 2021 •

edited by sync-by-unito bot