Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in ColumnConfig.java documentation #2171

Merged
merged 1 commit into from Nov 23, 2021

Conversation

logantracyo
Copy link
Contributor

The JDocs for two boolean methods contain an incorrect reference to date (likely a copy/pasted value that was not updated as were several other references) in the descriptions of setValueBoolean(String valueBoolean) and setDefaultValueBoolean(String defaultValueBoolean).

This commit corrects both to the proper term, boolean.

Environment

Liquibase Version: 4.5.0

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

The JDocs for two boolean methods contain an incorrect reference to `date` (likely a copy/pasted value that was not updated as other references had been) in the descriptions of `setValueBoolean(String valueBoolean)` and `setDefaultValueBoolean(String defaultValueBoolean)`.

This commit corrects both to the proper term, `boolean`.
Copy link
Contributor

@molivasdat molivasdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@molivasdat
Copy link
Contributor

Hi @logantracyo Thanks for fixing the JavaDocs.

This looks like a simple merge.

@molivasdat molivasdat merged commit 527aed8 into liquibase:master Nov 23, 2021
@logantracyo logantracyo deleted the patch-1 branch January 20, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants