Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions in CDILiquibase before rethrowing them #2397

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jan 24, 2022

Description

Alternative to #2355 that fixes #2354

Rather than logging the exceptions only within changeset iterator, better catch all exceptions and log them withing CDILiquibase.


Dev Handoff Notes (Internal Use)

Links

Testing

  • Steps to Reproduce: Have failing changelog in an CDI environment
  • Guidance:
    • Impact: Only impacts CDI

Dev Verification

Don't have a CDI environment to test in, but code is straightforward and issue author closed #2355 in favor of this fix.

┆Issue is synchronized with this Jira Bug by Unito

@kataggart
Copy link
Contributor

@nvoxland will add unit test to validate fix. @XDelphiGrl will verify functional tests are passing.

@kataggart kataggart removed the blocked label Feb 7, 2022
@nvoxland nvoxland merged commit 7f807d0 into master Feb 7, 2022
@nvoxland nvoxland deleted the log-exceptions-in-cdi branch February 7, 2022 23:06
@nvoxland nvoxland added this to the v4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print logs on ChangeSet exception
3 participants