New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Installer JDK to 17 #2602
Conversation
Notes and test results: Things to be aware of
Things to worry about
File Handling Notes My main worry was whether install4j would cleanly remove files from the 11 jvm that no longer exist in 17. If it didn't, that's also a potential problem even as we do patch releases. I know install4j doesn't remove the old driver jars on upgrade, but thought perhaps it handled it's bundled JVM differently. To test the jdk file handling, I:
From the comparison, I saw that new files like the h2 driver in the lib were added, but "removed" files were not actually removed in the lib dir as expected. BUT, the I did test this only on windows though, not mac. |
# Conflicts: # liquibase-dist/src/main/install4j/liquibase.install4j
For this Pr i compared the directories of an updated and a freshly installed builds from the windows installer, the only difference between them is autoUninstall file (there are 2 in the updated version). I also checked if liquibase is installing and running by default in java 17, and it looks like it. I also tried running a couple of commands on both builds and there is not any noticeable issue in any of them. Test environment: |
Description
Updates the version of Java installed as part of Liquibase in the installers to the latest Java 17 rather than 11, since 17 is the newest LTS version.