Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SnapshotCommandStep use the code from InternalSnapshotCommand directly DAT-9624 #2684

Merged
merged 12 commits into from
Apr 4, 2022

Conversation

wwillard7800
Copy link
Contributor

Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us on our discord channel

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

Unit Test Results

  4 125 files  ±0    4 125 suites  ±0   31m 31s ⏱️ - 4m 36s
  4 340 tests ±0    4 126 ✔️ +4     214 💤  - 4  0 ±0 
47 080 runs  ±0  42 448 ✔️ +4  4 632 💤  - 4  0 ±0 

Results for commit db46006. ± Comparison against base commit 41b1e2f.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation Mar 25, 2022
@suryaaki2 suryaaki2 requested review from StevenMassaro, suryaaki2 and nvoxland and removed request for suryaaki2 March 30, 2022 21:36
Conditioning++ automation moved this from To Do to Done Mar 31, 2022
@StevenMassaro StevenMassaro reopened this Apr 1, 2022
Conditioning++ automation moved this from Done to To Do Apr 1, 2022
@StevenMassaro StevenMassaro merged commit 8efaf39 into DAT-9298 Apr 4, 2022
Conditioning++ automation moved this from To Do to Done Apr 4, 2022
@StevenMassaro StevenMassaro deleted the DAT-9624 branch April 4, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants