Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize messaging for missing/invalid pro license keys (DAT-9403) #2690

Merged
merged 19 commits into from
Apr 4, 2022
Merged

standardize messaging for missing/invalid pro license keys (DAT-9403) #2690

merged 19 commits into from
Apr 4, 2022

Conversation

StevenMassaro
Copy link
Contributor

No description provided.

@StevenMassaro
first steps of removing places where liquibase pro subject is a hardc…
24553df 
…oded string
@StevenMassaro
add superset licenses to LicenseTier
1774dc5
@StevenMassaro
use the LicenseTier enum in more places
5fb5582
@StevenMassaro
add more null safety to LicenseServiceUtils.isProLicenseValid
f0cdc5c
@StevenMassaro
consolidate license env vars into one, recursively check other supers…
d772e7d 
…et licenses
@StevenMassaro
move LicenseTier into pro code
e73febd
@StevenMassaro
update javadoc
dd071f5
@StevenMassaro
change messaging to use liquibase.licenseKey not liquibase.pro.licens…
0fb320d 
…eKey
@StevenMassaro
remove /protrial links and replace with /trial link
0dfedc2
@StevenMassaro
Merge branch 'DAT-9298' into DAT-9602
9a0635c
@StevenMassaro
Merge branch 'DAT-9298' into DAT-9602
fef22cc
@StevenMassaro
allow both versions of the license key param in maven plugin
2d7bf3b
@StevenMassaro
standardize messaging for missing/invalid pro license keys
3a178a7
@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

Unit Test Results

  4 125 files  ±0    4 125 suites  ±0   33m 3s ⏱️ + 2m 5s
  4 340 tests ±0    4 122 ✔️  - 4     218 💤 +4  0 ❌ ±0 
47 080 runs  ±0  42 444 ✔️  - 4  4 636 💤 +4  0 ❌ ±0 

Results for commit cc3e66b. ± Comparison against base commit a33382a.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation Mar 28, 2022
@obovsunivskyii
Copy link
Contributor

all these functional test failures are expected and fixed separately on this PR. https://github.com/liquibase/liquibase-pro-tests/pull/296

Base automatically changed from DAT-9602 to DAT-9298 April 4, 2022 15:02
@StevenMassaro
Merge branch 'DAT-9298' into DAT-9403
cc3e66b 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/license/LicenseServiceUtils.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseDatabaseDiff.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseRollbackOneChangeSetMojo.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseRollbackOneChangeSetSQL.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseRollbackOneUpdateMojo.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseRollbackOneUpdateSQL.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/MavenUtils.java
@StevenMassaro StevenMassaro merged commit 5613746 into DAT-9298 Apr 4, 2022
Conditioning++ automation moved this from To Do to Done Apr 4, 2022
@StevenMassaro StevenMassaro deleted the DAT-9403 branch April 4, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryaaki2 suryaaki2 suryaaki2 approved these changes

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Conditioning++
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenMassaro @obovsunivskyii @suryaaki2