Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle URLs correctly in error conditions DAT-9882 #2709

Merged
merged 11 commits into from
Apr 19, 2022
Merged

Handle URLs correctly in error conditions DAT-9882 #2709

merged 11 commits into from
Apr 19, 2022

Conversation

wwillard7800
Copy link
Contributor

Environment

Liquibase Version:

Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>

Liquibase Extension(s) & Version:

Database Vendor & Version:

Operating System Type & Version:

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A clear and concise description of the issue being addressed. Additional guidance here.

  • Describe the actual problematic behavior.
  • Ensure private information is redacted.

Steps To Reproduce

List the steps to reproduce the behavior.

  • Please be precise and ensure private information is redacted
  • Include things like
    • Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
    • Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior

A clear and concise description of what happens in the software before this pull request.

  • Include console output if relevant
  • Include log files if available.

Expected/Desired Behavior

A clear and concise description of what happens in the software after this pull request.

Screenshots (if appropriate)

If applicable, add screenshots to help explain your problem.

Additional Context

Add any other context about the problem here.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us in the Liquibase Forum.

@suryaaki2
Copy link
Contributor

@wwillard7800 great job with units tests coverage for various platforms

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Unit Test Results

  4 125 files  ±    0    4 125 suites  ±0   37m 58s ⏱️ + 4m 56s
  4 367 tests +  27    4 153 ✔️ +  27     214 💤 ±0  0 ±0 
47 377 runs  +297  42 745 ✔️ +297  4 632 💤 ±0  0 ±0 

Results for commit 5980668. ± Comparison against base commit 09548e0.

♻️ This comment has been updated with latest results.

@suryaaki2 suryaaki2 merged commit 752983c into master Apr 19, 2022
@suryaaki2 suryaaki2 deleted the DAT-9882 branch April 19, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants