Do not throw a confusing error if a datatype specified as a changelog parameter is not expanded #2772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user specifies something that looks like a changelog parameter but doesn't match a specified parameter, liquibase simply users it as-is.
However, the DataType.fromDescription function that is used to determine the actual datatype to return cannot correctly handle a datatype that is formatted like a changelog parameter.
This fixes the datatype handling so it handles a datatype that looks like
${ ... }
as just a datatype it doesn't understand.Example Problem Changeset
Current behavior
Throws an
ArrayIndexOutOfBoundsException
exceptionFixed behavior
Fails with an error like
Syntax error in SQL statement "CREATE TABLE test_table (id ${INVALID }
which allows the user to recognize that they did not correctly set the changelog parameter