Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QCs for databases support to maven plugin (DAT-9623) #2814

Merged
merged 16 commits into from
May 5, 2022

Conversation

StevenMassaro
Copy link
Contributor

@StevenMassaro StevenMassaro commented May 2, 2022

Environment

Liquibase Version: N/A

Liquibase Integration & Version: maven

Liquibase Extension(s) & Version: N/A

Database Vendor & Version: N/A

Operating System Type & Version: N/A

Pull Request Type

  • Bug fix (non-breaking change which fixes an issue.)
  • Enhancement/New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add new parameters for QCs for databases to maven plugin.

Steps To Reproduce

N/A

Actual Behavior

N/A

Expected/Desired Behavior

Users can run QCs for databases checks through maven.

Screenshots (if appropriate)

Additional Context

This diff is going to be hard to review because it contains changes from the DAT-8375 branch, and master, both of which are not in the DAT-9298 branch.

Fast Track PR Acceptance Checklist:

Need Help?

Come chat with us in the Liquibase Forum.

@github-actions
Copy link

github-actions bot commented May 2, 2022

Unit Test Results

  4 512 files  ±0    4 512 suites  ±0   36m 18s ⏱️ +40s
  4 386 tests ±0    4 168 ✔️ ±0     218 💤 ±0  0 ±0 
51 912 runs  ±0  46 900 ✔️ ±0  5 012 💤 ±0  0 ±0 

Results for commit b136201. ± Comparison against base commit f1ce54b.

♻️ This comment has been updated with latest results.

@kataggart kataggart added this to To Do in Conditioning++ via automation May 2, 2022
# Conflicts:
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseChecksRunMojo.java
#	liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseChecksShowMojo.java
@StevenMassaro StevenMassaro merged commit 75f4f03 into DAT-9298 May 5, 2022
Conditioning++ automation moved this from To Do to Done May 5, 2022
@StevenMassaro StevenMassaro deleted the DAT-9623 branch May 5, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants