Simplify pro license checks to support running through maven (DAT-10003) #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAT-8375
…ed in the mojo declaration
DAT-9614: load values from propertyFile
Previously, the maven integration handled its own verification of the pro license key. This meant that specifying the key through the liquibase.properties file was not supported in maven. Now, instead of having maven do the license check, the license checks occur in the command step, and additionally, unneeded license check code from the Main.java class has been removed.
nvoxland
approved these changes
May 2, 2022
suryaaki2
approved these changes
May 2, 2022
This allows the license key to visible to downstream operations when they check for license keys.
# Conflicts: # liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseChecksRunMojo.java # liquibase-maven-plugin/src/main/java/org/liquibase/maven/plugins/LiquibaseChecksShowMojo.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Liquibase Version: N/A
Liquibase Integration & Version: maven
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: N/A
Operating System Type & Version: N/A
Pull Request Type
Description
Previously, the maven integration handled its own verification of the pro license key. This meant that specifying the key through the liquibase.properties file was not supported in maven. Now, instead of having maven do the license check, the license checks occur in the command step, and additionally, unneeded license check code from the Main.java class has been removed.
Steps To Reproduce
Run a pro only command through the maven integration and specify the pro key in liquibase.properties key.
Actual Behavior
Command fails because pro key cannot be found.
Expected/Desired Behavior
Command succeeds because pro key is read from properties file.
Screenshots (if appropriate)
Additional Context
Fast Track PR Acceptance Checklist:
Need Help?
Come chat with us in the Liquibase Forum.