Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
There is an issue in the XSD lookup logic, where it always pulls the XSD file over the network if the primary ResourceAccessor fails to find it and the "fallback" one does.
When we'd get to the fallback code, the
&& SECURE_PARSING)
would be false and make theif
block fail regardless of whether it found resources or not.The standard Liquibase integrations (CLI, Maven, etc.) set up the primary resource accessor so we never hit the problem code path, but custom setups could. The integration tests, for example, did hit the problem code.