Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaxb-core from 2.3.0.1 to 4.0.0 #2962

Merged
merged 2 commits into from Jun 17, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2022

Bumps jaxb-core from 2.3.0.1 to 4.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps jaxb-core from 2.3.0.1 to 4.0.0.

---
updated-dependencies:
- dependency-name: org.glassfish.jaxb:jaxb-core
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022

Unit Test Results

  4 548 files  ±0    4 548 suites  ±0   33m 9s ⏱️ - 1m 40s
  4 508 tests ±0    4 294 ✔️ +4     214 💤  - 4  0 ±0 
53 376 runs  ±0  48 368 ✔️ +4  5 008 💤  - 4  0 ±0 

Results for commit a3c754a. ± Comparison against base commit fc5ccbd.

♻️ This comment has been updated with latest results.

@nvoxland nvoxland added this to To Do in Conditioning++ via automation Jun 16, 2022
@nvoxland
Copy link
Contributor

Code Review and test results:

Things to be aware of

  • This is shipped with the CLI in order to provide XML parsing for java 9+
  • I added additional dependency exclusions since I saw there were different dependencies added to internal/lib that come from this which we don't need
  • I ran a liquibase update command with java 8, 11, and 17 locally to ensure the new version worked with all

Things to worry about

  • Did I get all the transitive dependencies removed? We should do a double-check of the internal/lib dir between 4.12.0 and this build to ensure nothing else was added

@nvoxland nvoxland requested a review from suryaaki2 June 16, 2022 23:47
@FBurguer FBurguer self-assigned this Jun 17, 2022
@FBurguer
Copy link

There is no new file in the internal/lib dir.
Also there are no issues working with Java 18, 11 or 8.

@nvoxland nvoxland merged commit 687baea into master Jun 17, 2022
Conditioning++ automation moved this from To Do to Done Jun 17, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.glassfish.jaxb-jaxb-core-4.0.0 branch June 17, 2022 18:54
@kataggart kataggart added this to the NEXT milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code sprint2022-27
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants