Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow individual commands to close the top-level OutputStream (System.out) #2999

Merged
merged 2 commits into from Jun 23, 2022

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This change prevents individual commands from closing the output stream they are provided, which is actually System.out. It is bad practice for code to close System.out particularly because other command steps will still expect it to be open.

Things to be aware of

Things to worry about

In very unusual circumstances, we might get more output than we did initially, because commands called after the RegisterChangelogCommandStep previously had a closed output stream. This isn't really a worry, and more of a positive thing.

Additional Context

@github-actions
Copy link

Unit Test Results

  4 169 files   -    379    4 169 suites   - 379   30m 54s ⏱️ -9s
  4 508 tests ±       0    4 294 ✔️ ±       0     214 💤 ±    0  0 ±0 
48 928 runs   - 4 448  44 361 ✔️  - 4 007  4 567 💤  - 441  0 ±0 

Results for commit 137a92a. ± Comparison against base commit 5aacdb4.

@wwillard7800 wwillard7800 merged commit a0d0519 into DAT-10419 Jun 23, 2022
@StevenMassaro StevenMassaro deleted the DAT-10419-issue-6 branch June 28, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants