Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test failing in different timezones #3059

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

mehrabisajad
Copy link
Contributor

@mehrabisajad mehrabisajad commented Jul 13, 2022

Impact

  • Enhancement/New feature (adds functionality without impacting existing logic)

  • Breaking change (fix or feature that would cause existing functionality to change)

  • Bug fix (non-breaking change which fixes expected existing functionality)

Description

The regular expression was edited for time zones with a half-hour offset and a 45-minute offset so that the test could run successfully.
like : UTC−03:30 and UTC+03:30

@kataggart kataggart added this to To Do in Conditioning++ via automation Jul 13, 2022
@github-actions
Copy link

Unit Test Results

  4 608 files  ±0    4 608 suites  ±0   32m 58s ⏱️ - 3m 29s
  4 589 tests ±0    4 375 ✔️ ±0     214 💤 ±0  0 ±0 
54 240 runs  ±0  49 232 ✔️ ±0  5 008 💤 ±0  0 ±0 

Results for commit dd96535. ± Comparison against base commit bcd2d53.

@nvoxland
Copy link
Contributor

Code review and test results:

Things to be aware of:

  • Change to make the test assertion less "assume the minutes are the same" makes sense given the problem
  • Only changes a test

Things to worry about:

  • Nothing

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR addresses a failing test.
  • No additional testing required.

APPROVED

Although the change in this PR could not impact any of the test suites, I'm including links to passing runs for completeness.
Passing Functional Tests
Passing Test Harness Execution

@nvoxland nvoxland merged commit 68c01b5 into liquibase:master Jul 20, 2022
Conditioning++ automation moved this from To Do to Done Jul 20, 2022
@kataggart kataggart added this to the NEXT milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants