Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added duplicateFileMode setting for maven plugin #3119

Merged
merged 1 commit into from Aug 2, 2022

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Jul 27, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds a maven-native flag for the liquibase.duplicateFileMode setting introduced in #3006

The config-level tag is <duplicateFileMode> and the global maven property to set is liquibase.duplicateFileMode

Fixes #3097

Things to be aware of

  • Parsing of the value is case insensitive
  • Invalid values should throw a parse value
  • Applies to all maven commands that use a changelog (extends AbstractLiquibaseChangeLogMojo)

Things to worry about

  • Nothing

@github-actions
Copy link

github-actions bot commented Jul 27, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   38m 22s ⏱️ + 4m 12s
  4 594 tests ±0    4 375 ✔️  - 4     219 💤 +4  0 ±0 
54 300 runs  ±0  49 276 ✔️  - 4  5 024 💤 +4  0 ±0 

Results for commit a768cd6. ± Comparison against base commit 28631d9.

♻️ This comment has been updated with latest results.

@nvoxland
Copy link
Contributor Author

Code review and test results:

Things to be aware of:

  • Needs manual testing still

Things to worry about:

  • Nothing

@nvoxland nvoxland requested a review from suryaaki2 July 28, 2022 01:58
@kataggart kataggart added this to To Do in Conditioning++ via automation Aug 1, 2022
@FBurguer
Copy link

FBurguer commented Aug 2, 2022

For this PR I tested:
The config-level tag <duplicateFileMode> with WARN: PASS
The config-level tag <duplicateFileMode> with ERROR: PASS
Without the config-level tag <duplicateFileMode> (Needs to be ERROR by default): PASS
If you have a properties file with liquibase.duplicateFileMode and add the config-level tag <propertyFile> it doesnt read it. You can only set it as a config-level tag

@nvoxland nvoxland merged commit 05b3f1b into master Aug 2, 2022
Conditioning++ automation moved this from To Do to Done Aug 2, 2022
@nvoxland nvoxland deleted the maven-duplicate-file-mode branch August 2, 2022 19:01
@kataggart kataggart added this to the v4.15.0 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add liquibase.duplicateFileMode to maven plugin
4 participants