Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when no test system has been found #3185

Merged
merged 3 commits into from Feb 28, 2024

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Aug 19, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As an occasionally forgetful developer, sometimes I neglect to specify which test systems I want to use or forget to update them when switching contexts. If I fail to specify any appropriate test system and run the command tests framework I will see a confusing error:

Process finished with exit code 255

org.spockframework.runtime.SpockExecutionException: Data provider has no data

This change updates the error message to:

Process finished with exit code 255

java.lang.RuntimeException: Required test systems not found! Make sure your test systems are specified in your liquibase.sdk.yaml and that you are not accidentally filtering out all tests.

Things to be aware of

Throws an exception when there are no suitable test systems to run tests with. Previously spock would throw an exception when trying to build out the test case.

Things to worry about

This should not have any impact on the pipeline and should just be an enhancement for local development.

@abrackx abrackx self-assigned this Aug 19, 2022
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   34m 11s ⏱️ -17s
  4 641 tests ±0    4 415 ✔️ ±0     226 💤 ±0  0 ±0 
54 696 runs  ±0  49 633 ✔️ ±0  5 063 💤 ±0  0 ±0 

Results for commit 4030924. ± Comparison against base commit ea43d36.

♻️ This comment has been updated with latest results.

@abrackx abrackx marked this pull request as ready for review August 19, 2022 18:57
@abrackx abrackx requested a review from nvoxland as a code owner August 19, 2022 18:57
@StevenMassaro StevenMassaro merged commit 4da8363 into master Feb 28, 2024
1 check passed
@StevenMassaro StevenMassaro deleted the improve-test-system-error branch February 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants