Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAT-10810 QC: checks show changes (--show-cols flag, drop some, etc) #3187

Merged
merged 11 commits into from Sep 6, 2022
Merged

DAT-10810 QC: checks show changes (--show-cols flag, drop some, etc) #3187

merged 11 commits into from Sep 6, 2022

Conversation

diadiushko
Copy link
Contributor

@diadiushko diadiushko commented Aug 22, 2022 •
edited

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Minor changes within TableOutput class.
Adding toLowerWithoutWhitespaces method to StringUtil class.
example:
" InPu t " -> "input"

Additional Context

Changes were made to support https://github.com/liquibase/liquibase-pro/pull/628.

@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   37m 0s ⏱️ +43s
  4 620 tests +  1    4 405 ✔️ +  5     215 💤  - 4  0 ❌ ±0 
54 612 runs  +12  49 592 ✔️ +16  5 020 💤  - 4  0 ❌ ±0 

Results for commit adf2061. ± Comparison against base commit 4c08102.

♻️ This comment has been updated with latest results.

@suryaaki2 suryaaki2 marked this pull request as ready for review August 23, 2022 14:05
nvoxland
nvoxland approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment on something good to fix, but still marking it as approved so I don't have to be a bottleneck in re-approving it

liquibase-core/src/main/java/liquibase/util/StringUtil.java Show resolved Hide resolved
@obovsunivskyii obovsunivskyii reopened this Sep 6, 2022
@diadiushko diadiushko merged commit 8c3043c into master Sep 6, 2022
@diadiushko diadiushko deleted the DAT-10810 branch September 6, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenMassaro StevenMassaro StevenMassaro left review comments

@nvoxland nvoxland nvoxland approved these changes

@wwillard7800 wwillard7800 wwillard7800 approved these changes

@abrackx abrackx Awaiting requested review from abrackx

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@diadiushko @nvoxland @wwillard7800 @StevenMassaro @obovsunivskyii @adiadiushko @abrackx