Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply sqlVisitors to CompoundStatements on DB2z #3220

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

MichaelKern-IVV
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #3219:

Use

<createIndex indexName="UNI500O1" tableName="UNT500O">
    <column name"MDT_ID"/>
</createIndex>

and append some advanced options

<modifySql>
    <append value="USING STOGROUP IGVIX001 BUFFERPOOL BP0"/>
</modifySql>

When running the update command on DB2z, the options are currently not appended.

The updateSql command, on the other hand, works correctly.

@nvoxland nvoxland added the SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions label Aug 31, 2022
@github-actions
Copy link

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   39m 58s ⏱️ + 2m 31s
  4 617 tests ±0    4 402 ✔️ +4     215 💤  - 4  0 ±0 
54 576 runs  ±0  49 556 ✔️ +4  5 020 💤  - 4  0 ±0 

Results for commit 2234248. ± Comparison against base commit e742a88.

Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and test results:

Things to be aware of:

  • Code change makes sense, the old version was not using a needed parameter
  • Only impacts db2z

Things to worry about:

  • Nothing

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liquibase honors the modify-sql changetype during the update command for DB2 on Z.

APPROVED

modify-sql ChangeType Documentation

@nvoxland nvoxland merged commit 895605a into liquibase:master Sep 19, 2022
@kataggart kataggart added this to the NEXT milestone Sep 20, 2022
@tabbyf00
Copy link

Thanks for your PR submission! We just finished reviewing and merging it into the 4.17.0 release on October 10, 2022. When you get a chance, could you please Star the Liquibase project? The star button is in the upper right corner of the screen.

@MichaelKern-IVV MichaelKern-IVV deleted the issue/modifySql branch September 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocandidate DBDB2Z DBVUnverified SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions Severity2 sprint2022-34 TypeBug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

sqlVisitors are NOT applied to CompoundStatements on DB2z
7 participants