Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog null check to fix initializing a MSSQL db issue #3235

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

MalloD12
Copy link
Contributor

@MalloD12 MalloD12 commented Sep 1, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

A null check has been added in order to avoid having issues when trying to run a Liquibase command like "generateChangeLog" proving only the defaultSchemaName.

Fixes #3181

Things to be aware of

  • nothing

Things to worry about

  • nothing

Additional Context

  • nothing

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results

  4 620 files  ±0    4 620 suites  ±0   32m 0s ⏱️ - 4m 17s
  4 619 tests ±0    4 404 ✔️ +4     215 💤  - 4  0 ±0 
54 600 runs  ±0  49 580 ✔️ +4  5 020 💤  - 4  0 ±0 

Results for commit cd154e3. ± Comparison against base commit 4c08102.

♻️ This comment has been updated with latest results.

.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@nvoxland nvoxland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now, thanks @MalloD12

@FBurguer
Copy link

This PR looks good, I tried connecting to db with defaultSchemaName param with liquibase 4.16.1 and this build with the same credentials, 4.16.1 failed with [Failed SQL: (156) USE null] and this build could conect without any aparent issues.

@nvoxland nvoxland merged commit 5be42f1 into master Sep 26, 2022
@nvoxland nvoxland deleted the cli-fix-3181 branch September 26, 2022 20:59
@nvoxland nvoxland added this to the 1NEXT milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SQL Server - Incorrect syntax near the keyword 'null'. [Failed SQL: (156) USE null]
4 participants