Fix "double" handling with H2

[MalloD12]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix double type column parsing when double type is specified with precision (i.e. double(25)).

Fixes #3099

Things to be aware of

• Added logic to parse double(xy) as a "Double Precision" for H2 database.
• Only impact on H2 database.

Things to worry about

• Nothing.

Additional Context

• Nothing.

[github-actions]

Unit Test Results

  4 620 files  ±  0    4 620 suites  ±0   35m 32s ⏱️ -41s
  4 621 tests +  1    4 406 ✔️ +  1     215 💤 ±0  0 ❌ ±0 
54 624 runs  +12  49 604 ✔️ +12  5 020 💤 ±0  0 ❌ ±0 

Results for commit b4f5563. ± Comparison against base commit 31484f1.

♻️ This comment has been updated with latest results.

[nvoxland]

Looking at the docs, it looks like h2 1.x supported "double" and "double precision" as aliases for each other, but 2.x only supports "double precision. Neither version supports arguments, so I simplified the code down to just "always return double precision"

[XDelphiGrl]

Fix addresses a bug in Liquibase SQL generation for the DOUBLE PRECISION datatype.

• New unit tests added to validate input of "double" and "double(20)"; both inputs are expect to return DOUBLE PRECISION.
  • H2 itself does not support providing precision, but Liquibase will handle such input as DOUBLE PRECISION.
• No additional testing required.

APPROVED

[TomBenjamins]

Could you please apply this fix also to the BIGINT, INTEGER, BOOLEAN types?

#3099 (comment)

this bug is blocking for us to upgrade to h2 v2.

[bhuism]

+1

[richardmLL]

+1

[hilkojacobse]

+1

[MalloD12]

@TomBenjamins We have already applied a similar fix for INT(xt). I wasn't aware this was also an issue for BOOLEAN and BIGINT. I'll discuss it today with the team and get back to you guys. Thanks for the feedback.

[MalloD12]

Hey guys, I just want to let you know I'll be creating a separate issue to address BIGINT and BOOLEAN types. For INTEGER, we already have an open issue for that. But I would also like to ask you if you guys can share some example (changelog/changeset) on how you are using these types.

Thanks,
Daniel.

[TomBenjamins]

Hello Daniel,

for us the only blocking one is BIGINT, as that one is being used in nearly all our table creation scripts.
On mysql it still works fine, but on H2 v2 we get similar syntax exceptions as described in this issue and #3099
If you can provide me the new issue link I can add a liquibase example for at least the BIGINT issue there.

greetings,

Tom

[MalloD12]

Hey @TomBenjamins I have just created this issue, please have a look to it and feel free to edit/anything you guys consider relevant for me when working on it.

Thanks,
Daniel.