Remove snowflake unsupported logging from snapshot command (DAT-11291) #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public static void logUnsupportedDatabase(Database database, Class callingClass) { | ||
| if (LicenseServiceUtils.isProLicenseValid()) { | ||
| if (!(database instanceof MSSQLDatabase | ||
| || database instanceof OracleDatabase | ||
| || database instanceof MySQLDatabase | ||
| || database instanceof DB2Database | ||
| || database instanceof PostgresDatabase)) { | ||
| || database instanceof PostgresDatabase | ||
| || database.getShortName().equalsIgnoreCase("snowflake"))) { |
There was a problem hiding this comment.
Do we have to do this hacky because adding a dependency on the snowflake module would cause a circular dependency?
There was a problem hiding this comment.
Yep. Until that module is fully integrated into core we've got to use this hack. I talked it through with @nvoxland but I should probably also add a TODO. I'll do that now!
StevenMassaro
approved these changes
Sep 16, 2022
suryaaki2
approved these changes
Sep 16, 2022
nvoxland
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Removes message
INFO This command might not yet capture Liquibase Pro additional object types on snowflakewhen running snapshot against snowflake.Things to be aware of
Removed duplicate code from SnapshotCommandStep.
Things to worry about
N/A
Additional Context
N/A