Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed createView handling of replaceIfExists=true when the string "replace" exists in the view definition #3305

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

filipelautert
Copy link
Collaborator

@filipelautert filipelautert commented Sep 26, 2022

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

  • None

Things to worry about

  • None

Additional Context

  • None

…by verifying if the "OR" statement is added to the code; creates some testing test.
@github-actions
Copy link

Unit Test Results

  4 668 files  +12    4 668 suites  +12   36m 45s ⏱️ - 7m 4s
  4 631 tests +  3    4 416 ✔️ +  3     215 💤 ±0  0 ±0 
54 744 runs  +36  49 724 ✔️ +36  5 020 💤 ±0  0 ±0 

Results for commit a23e3d8. ± Comparison against base commit 031928b.

@filipelautert filipelautert changed the title Fixes #1849 (create or replace view not being generated as expected) … Fixed createView handling of replaceIfExists=true when the string "replace" exists in the view definition Sep 26, 2022
Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR fixes a bug where including the string "replace" in a SELECT statement for a view was improperly handled when createOrReplace=true.

  • New unit tests added to validate createOrReplace=false and createOrReplace=true with the string "replace" in the SELECT statement.
  • No additional testing required.

APPROVED

@nvoxland nvoxland merged commit 8b759d7 into master Sep 28, 2022
@nvoxland nvoxland deleted the 1849-fix-create-view-with-replace branch September 28, 2022 20:12
@nvoxland nvoxland added this to the 1NEXT milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

createView replaceIfExists doens't work if using replace function in view definition
4 participants