Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAT-11407: replace backslashes in NotFoundResource URI #3322

Merged
merged 95 commits into from
Sep 29, 2022
Merged

DAT-11407: replace backslashes in NotFoundResource URI #3322

merged 95 commits into from
Sep 29, 2022

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Replace an illegal character when creating the not found resource.

Things to be aware of

Things to worry about

Additional Context

@nvoxland
Added liquibase.resoure.Resource interface
8d37a81
@nvoxland
Added liquibase.resoure.Resource interface
4d2f8c4 
- Created ResourceAccessor.find() that returns a single file
- Moved openStream warn/error logic in to ResourceAccessor.find
- Use new openOutputStream logic in ChangelogRewriter
- Replaced URIs with String descriptions in InputStreamList
@nvoxland
Replaced Resource.find() return value with SortedSet
af8c491
@nvoxland
Removed UnknownResource
c1ef4f3 
Added isWritable() and exists() methods to Resource
@nvoxland
Merge branch 'master' into add-resource
9364b3f
@nvoxland
Playing with ResourceAccessor changes
8f45532
@nvoxland
Merge remote-tracking branch 'origin/master' into add-resource
c4b391d
@nvoxland
Playing with ResourceAccessor changes
8f84daf
@nvoxland
Merge branch 'master' into add-resource
b1fe207
@nvoxland
Merge remote-tracking branch 'origin/master' into add-resource
5ee63db
@nvoxland
Playing with ResourceAccessor changes
3bc133e
@nvoxland
Playing with ResourceAccessor changes
6920510
@nvoxland
Playing with ResourceAccessor changes
d415599
@nvoxland
Playing with ResourceAccessor changes
4c42522
@nvoxland
Playing with ResourceAccessor changes
1fa84fb
@nvoxland
Playing with ResourceAccessor changes
8200f30
@nvoxland
Playing with ResourceAccessor changes
69f53ee
@nvoxland
Playing with ResourceAccessor changes
15bb405
@nvoxland
Playing with ResourceAccessor changes
3edac0f
@nvoxland
Playing with ResourceAccessor changes
fc37561
@nvoxland
Revert "Playing with ResourceAccessor changes"
0a5ffc6 
This reverts commit fc37561.
@nvoxland
Revert "Playing with ResourceAccessor changes"
f793f0c 
This reverts commit 3edac0f.
@nvoxland
Revert "Playing with ResourceAccessor changes"
daf680d 
This reverts commit 15bb405.
@nvoxland
Revert "Playing with ResourceAccessor changes"
3052c99 
This reverts commit 69f53ee.
@nvoxland
Playing with ResourceAccessor changes
363efcd
@nvoxland
Playing with ResourceAccessor changes
80e7554
@nvoxland
Playing with ResourceAccessor changes
c070dcb
@nvoxland
Playing with ResourceAccessor changes
6b3fad1
@nvoxland
Playing with ResourceAccessor changes
c06e9b6
@nvoxland
Playing with ResourceAccessor changes
d12a738
StevenMassaro and others added 19 commits September 20, 2022 11:49
@StevenMassaro
DAT-11505: use proper file not found message for execute-sql (#3287)
443bc7f 
Use the proper message for files not found when running execute-sql command.
@nvoxland
Merge remote-tracking branch 'origin/DAT-10431' into add-resource
1a932ba 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/resource/DirectoryPathHandler.java
#	liquibase-core/src/main/java/liquibase/resource/ZipPathHandler.java
#	liquibase-core/src/test/groovy/liquibase/resource/ZipPathHandlerTest.groovy
@nvoxland
Merged DAT-10431 into add-resource
599f3ad
@nvoxland
Merge branch 'add-resource-updates' into add-resource
14cd137 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/resource/DirectoryPathHandler.java
#	liquibase-core/src/main/java/liquibase/resource/PathHandlerFactory.java
#	liquibase-core/src/test/groovy/liquibase/resource/PathHandlerFactoryTest.groovy
@nvoxland
Merged add-resource-update into add-resource
d00710c
@nvoxland
Merge branch 'master' into add-resource
4f825b8 
# Conflicts:
#	liquibase-core/src/test/groovy/liquibase/resource/ClassLoaderResourceAccessorTest.groovy
#	liquibase-core/src/test/groovy/liquibase/resource/FileSystemResourceAccessorTest.groovy
@StevenMassaro
use Resource classes in db-doc command (DAT-11549) (#3297)
be18b18 
support writing dbdoc to s3
@nvoxland
Removed new attempts at combining searchPath and direct paths for exi…
a0f8946 
…sting logic
@nvoxland
Merge remote-tracking branch 'origin/DAT-10431' into DAT-10431
4c7e6e2 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/resource/DirectoryPathHandler.java
#	liquibase-core/src/main/java/liquibase/resource/ZipPathHandler.java
#	liquibase-core/src/test/groovy/liquibase/resource/ZipPathHandlerTest.groovy
@nvoxland
Merge branch 'add-resource' into DAT-10431
f35066e 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/resource/DirectoryPathHandler.java
@nvoxland
Removed PathHandlerFactory.getResource with includeResourceAccessor
897a9e4
@nvoxland
Added extra commit to reopen branch
28697cc
@nvoxland
Revert code to using computed fileName vs. resource.getPath()
4ea3f89
@nvoxland
Moved test for removed isAbsolute() for linux
76fd78a
@StevenMassaro
reapply DAT-11591 fix
a5b5f8d
@wwillard7800 @StevenMassaro
Check for existence before adding resources directory in registerChan…
bc35950 
…geLog Mojo (#3302)

* Check for resources directory to exist before adding it to resource accessor

DAT-11714

* reapply DAT-11591 fix

Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com>
@StevenMassaro
allow copying command test files to CWD (DAT-11406) (#3265)
0c6d23f 
Update the command test framework to allow copying files to the current working directory.
@StevenMassaro
Merge branch 'master' into DAT-10431
9317d23 
# Conflicts:
#	liquibase-integration-tests/src/test/java/liquibase/dbtest/AbstractIntegrationTest.java
@StevenMassaro
replace backslashes in NotFoundResource URI
9386cfc
@nvoxland nvoxland changed the base branch from DAT-10431 to add-resource September 29, 2022 14:46
@github-actions
Copy link

Unit Test Results

  4 668 files  ±0    4 668 suites  ±0   34m 51s ⏱️ - 2m 57s
  4 627 tests ±0    4 409 ✔️ ±0     218 💤 ±0  0 ❌ ±0 
54 528 runs  ±0  49 485 ✔️ ±0  5 043 💤 ±0  0 ❌ ±0 

Results for commit 9386cfc. ± Comparison against base commit 9317d23.

Base automatically changed from add-resource to master September 29, 2022 14:57
@StevenMassaro
Merge branch 'master' into DAT-11407
6a7eee0 
# Conflicts:
#	liquibase-core/src/main/java/liquibase/integration/commandline/Main.java
#	liquibase-core/src/main/java/liquibase/resource/ResourceAccessor.java
@StevenMassaro StevenMassaro merged commit b22e3d0 into master Sep 29, 2022
@StevenMassaro StevenMassaro deleted the DAT-11407 branch September 29, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland nvoxland nvoxland approved these changes

@abrackx abrackx Awaiting requested review from abrackx

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

@wwillard7800 wwillard7800 Awaiting requested review from wwillard7800

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StevenMassaro @nvoxland @wwillard7800 @abrackx