Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle absolute path in getAll method DAT-11890 #3369

Merged
merged 8 commits into from Oct 19, 2022
Merged

Handle absolute path in getAll method DAT-11890 #3369

merged 8 commits into from Oct 19, 2022

Conversation

wwillard7800
Copy link
Contributor

Do not allow absolute paths in this method

@github-actions
Copy link

github-actions bot commented Oct 13, 2022 •
edited

Unit Test Results

  4 668 files  ±  0    4 668 suites  ±0   39m 40s ⏱️ + 5m 12s
  4 642 tests +  1    4 416 ✔️ +  1     226 💤 ±0  0 ❌ ±0 
54 708 runs  +12  49 645 ✔️ +12  5 063 💤 ±0  0 ❌ ±0 

Results for commit 00c2573. ± Comparison against base commit ea43d36.

♻️ This comment has been updated with latest results.

StevenMassaro
StevenMassaro reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@StevenMassaro StevenMassaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to write a test around this change?

@wwillard7800
Copy link
Contributor Author

Are you able to write a test around this change?

Yes. I had written a unit test originally, and then it got lost. I added it again.

@suryaaki2 suryaaki2 merged commit c439c08 into master Oct 19, 2022
@filipelautert filipelautert deleted the DAT-11890 branch April 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenMassaro StevenMassaro StevenMassaro left review comments

@nvoxland nvoxland nvoxland approved these changes

@suryaaki2 suryaaki2 suryaaki2 approved these changes

@abrackx abrackx Awaiting requested review from abrackx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wwillard7800 @nvoxland @StevenMassaro @suryaaki2