Restore FileSystemResourceAccessor and add tests. #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryaaki2
approved these changes
Nov 23, 2022
XDelphiGrl
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
This PR deprecates the FileSystemResourceAccessor class. Deprecated classes may be removed in future releases. It is best to update usage of FileSystemResourceAccessor to instead use either DirectoryResourceAccessor or ZipResourceAccessor.
- A comprehensive set of tests added for the FileSystemResourceAccessor class.
- Functional automated tests are passing.
- Test harness execution fails for an unrelated reason during Firebird tests; nothing to worry about.
APPROVED
filipelautert
deleted the
3478-restore_filesystemresourceaccessor-removed-in-4170
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
The class liquibase.resource.FileSystemResourceAccessor is absent from the 4.17.0 release, but it was still present in 4.16.0 and was dropped without deprecation. This PR restores the class as deprecated and add tests.