Code cleanup: avoid re-calling methods #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvoxland
changed the title
MalloD12
added
the
SafeToBuild
MalloD12
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Approved.
Review and testing results:
Changes look good to me, thank you @arturobernalg. Functional tests are failing because of some Show-Summary functional tests (not related with this PR) are failing. I'll investigate that separately with the team.
Things to be aware of:
- None
Things to worry about:
- None
…/liquibase into arturobernalg-feature/expression
MalloD12
removed
the
SafeToBuild
MalloD12
added
the
SafeToBuild
filipelautert
approved these changes
May 5, 2023
filipelautert
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Avoid multiple equivalent occurrences of the same expression within a method (or constructor, or class initializer) if the result of the expression can be reused.