New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not using imported classes and packages in the source file. #3836
Conversation
Initial/Pre-Review Thoughts Does not actually impact functionality, just compilation so as long as it's only imports then "still compiles" is all the test that's really needed. Questions I have:
Potential risks:
What could make the full review difficult:
|
…uibase into arturobernalg-feature/import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Review and testing results:
Changes look good to me. Integration tests were failing, but it was due some SHOW_SUMMARY
missing changes I added to fix these tests. Functional tests are failing because of the same reason (not related with this PR). I'll investigate that separately with the team.
Things to be aware of:
- None
Things to worry about:
- None
Impact
Description
Remove not using imported classes and packages in the source file.