New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "author" command argument for diffChangelog command #3990
Implement "author" command argument for diffChangelog command #3990
Conversation
Initial/Pre-Review Thoughts Changes make sense to me. Thanks! Questions I have:
Potential risks:
What could make the full review difficult:
|
…ffChangelog # Conflicts: # liquibase-core/src/main/java/liquibase/command/core/DiffChangelogCommandStep.java
Hello @vitaliyg2 , thanks for the improvement! |
Hi @filipelautert, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vitaliyg2 , Adding the parameter to a test seems enough.
…/liquibase into feature/authorForDiffChangelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The author
property for generate-changelog
is hidden from the help. Given that we're expanding the usage of author
to diff-changelog
, the author
property should be visible in help for both commands.
A quick test did verify that despite not appearing in the help, generate-changelog
accepts and uses the author
property.
CHANGES REQUESTED
Thanks @vitaliyg2 for unhiding author field for generate-changelog! |
Functional tests started here: https://github.com/liquibase/liquibase-pro-tests/actions/runs/4993639743 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you ever wish you could generate a changelog or diff-changelog and specify an author name, instead of relying on the autogenerated author name? Now you can! This PR introduces a new diff-changelog
command property author
that Liquibase uses to popluate the author attribute on generated changesets. Generate-changelog
already implemented the author
command property, but it was hidden from the help. The property is now correctly documented in the CLI help for both diff-changelog
and generate-changelog
.
- Integration tests expanded to validate the new functionality.
- Light manual testing of
diff-changelog --author customAuth
for all changelog formats passing. - Test harness failures are unrelated to this PR and can be disregarded.
- Functional tests passing.
APPROVED
Hi All, big thanks for adding this feature ❤️. In my original feature request, I only mentioned that the |
Hello @unlimitedsola ! Sure, please feel free to create a new pr. The more features the merrier :) |
Impact
Description
Currently there is no way to specify changesets author for changesets generated by the diffChangelog command.
This implements support of the author command argument for the diffChangelog command, same way as it's implemented for the generateChangelog command.
This allows to specify author for diffChangelog in properties file or from the command line, also implemented changeSetAuthor property for Maven plugin (same way as it is implemented for generateChangelog command).
Fixes #1610
Things to be aware of
Implementation is based on the generateChangelog command.