Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-3256: STRICT=true description #4115

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

adrian-velonis1
Copy link
Contributor

https://datical.atlassian.net/browse/PD-3256

Providing more useful description for STRICT global config; minor tweaks to other descriptions

@filipelautert
Copy link
Collaborator

Hi @adrian-velonis1 - is this one still valid?

@adrian-velonis1
Copy link
Contributor Author

@filipelautert Yes this is still valid AFAIK!

@filipelautert
Copy link
Collaborator

@filipelautert Yes this is still valid AFAIK!

Thanks @adrian-velonis1 ! I fixed the merge conflicts, could you take a last look to see if it still ok? Then I can merge it.

@filipelautert
Copy link
Collaborator

@adrian-velonis1 Ouch, tests needs to be fixed as in the last PR you created and Steve reviewed.

adrian-velonis1 and others added 3 commits June 25, 2024 16:36
https://datical.atlassian.net/browse/PD-3256

Providing more useful description for STRICT global config; minor tweaks to other descriptions
@filipelautert filipelautert merged commit 339205d into master Jun 26, 2024
42 of 43 checks passed
@filipelautert filipelautert deleted the adrian-velonis1-patch-1 branch June 26, 2024 14:11
@filipelautert filipelautert added this to the 1NEXT milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants