Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Running Changeset: " logs written directly to stdout instead of using the maven logger #4157

Merged
merged 1 commit into from May 17, 2023

Conversation

mensinda
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

I am categorizing this as a bugfix and not an enhancement, since I don't think that using the default ConsoleUIService (which writes to stdout) was intended.

Description

With this PR, the "Running Changeset: " logs are written with the maven logger and not directly to stdout.

Things to be aware of

Impact on the codebase: minimal

Things to worry about

Nothing

Additional Context

@nvoxland
Copy link
Contributor

nvoxland commented May 3, 2023

Initial/Pre-Review Thoughts
Thanks for the fix, @mensinda!

The change looks right to me. The UIService is there to adapt to whatever "UI" a particular integration has, and for maven their UI is the logs.

It may make for some duplicate log messages, but the fix for that is larger and should be handled in a separate PR at some point, likely thinking about UI vs. logs more in general.

Questions I have:

  • None

Potential risks:

  • None

What could make the full review difficult:

  • Nothing

@filipelautert filipelautert self-assigned this May 15, 2023
@filipelautert filipelautert added sprint2023-51 SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels May 15, 2023
@filipelautert
Copy link
Collaborator

Hello @mensinda - PR #4152 was merge last week and coincidentally it has a method with the same that you used. Could you merge your changes to it? I believe your code would be added around line 633 -: https://github.com/liquibase/liquibase/pull/4152/files#diff-bbe8f062b4c3acf56905d187f674c41575cc99e3b114267095848997859f5926R633 ?
Thanks!

This way the "Running Changeset: " logs are written with the maven
logger and not directly to stdout.
@mensinda
Copy link
Contributor Author

Hello @filipelautert, I have updated the PR.

@filipelautert filipelautert added SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions and removed SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions labels May 15, 2023
Copy link
Collaborator

@filipelautert filipelautert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @mensinda !

Copy link
Contributor

@XDelphiGrl XDelphiGrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR improves Liquibase Maven Plugin logging by using the the Maven Log UI instead of stdout for writing some messages.

  • Functional and test harness executions passing. There were some failures in an earlier test harness run, but those are resoleved here.
  • No additional testing required.

APPROVED

@filipelautert filipelautert merged commit 8df7854 into liquibase:master May 17, 2023
31 of 33 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone May 17, 2023
@mensinda mensinda deleted the mavenLogUi branch May 22, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SafeToBuild Indicates that a particular PR contains changes which are safe to build using GitHub actions sprint2023-51 TypeBug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants