[DAT-6608] Refactors DropAll command as CommandStep #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d no one noticed that (calling dropAllInternal when the correct was internalDropAll) . Removing it.
Refactored to DropAllCommandStep. Also removed changelogFile parameter - it was used only for HUB.
filipelautert
requested review from
StevenMassaro,
wwillard7800,
abrackx and
suryaaki2
StevenMassaro
approved these changes
Apr 25, 2023
liquibase-standard/src/main/java/liquibase/command/core/DropAllCommandStep.java
Outdated
Show resolved
Hide resolved
suryaaki2
approved these changes
Apr 25, 2023
# Conflicts: # liquibase-integration-tests/src/test/groovy/liquibase/command/util/CommandUtil.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
DAT-6608 - Refactors DropAll command as CommandStep
dropAllInternalwhen the correct wasinternalDropAll) . Removing it.Things to notice