Fix DB2 integration tests DAT-13113

[wwillard7800]

Impact

• Bug fix (non-breaking change which fixes expected existing functionality)
• Enhancement/New feature (adds functionality without impacting existing logic)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

The Db2IntegrationTest had issues

Things to be aware of

Things to worry about

Additional Context

[StevenMassaro]

Nice work!! Question for you - is it possible to fix this in the testcontainers repo, rather than fix it here? I'm sure there are other people who would like to get these fixes.

[abrackx]

Wowowow I never thought I'd see the day! Nice work!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

40.0% Coverage
0.0% Duplication

[filipelautert]

Nice work!! Question for you - is it possible to fix this in the testcontainers repo, rather than fix it here? I'm sure there are other people who would like to get these fixes.

Good question! I think I can open an issue for them with my findings. It's quite simple - the code below makes it fail:

        Db2Container container = new Db2Container()
                .withUsername("lbuser")
                .withPassword("lbpass")
                .withDatabaseName("lbcat")
                .acceptLicense();

        List<PortBinding> portBindings = Collections.singletonList(new PortBinding(Ports.Binding.bindPort(50000), new ExposedPort(50000)));
        container.withCreateContainerCmdModifier(cmd -> cmd.withHostConfig(new HostConfig().withPortBindings(portBindings)));
        container.start();

If I exclude the container.withCreateContainerCmdModifier it works. We do it as part of our start method, but seems it is not required (at least for DB2) - and when it's done for DB2 it breaks the database startup. Also after finding it out I changed the PR again, now it's a lot more simple.

I'll create an issue at their github.

[filipelautert]

@StevenMassaro testcontainers/testcontainers-java#7679

[filipelautert]

@abrackx in fact the entire fix is here.