Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified expressions, removed redundant expressions, fixed javadocs #4301

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

anton-erofeev
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@MalloD12 MalloD12 self-assigned this Jun 13, 2023
@MalloD12 MalloD12 self-requested a review June 13, 2023 20:03
Copy link
Collaborator

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Even though there is no description of the changes done it is mostly what the PR summary says removing unused code, redundant expressions, fixed javadocs, unused imports, etc. No business logic code was made.

Build and tests successfully executed (except functional tests which are failing due to un-related reasons).

@rberezen
Copy link
Contributor

@anton-erofeev Could you kindly help resolve the conflict in the pull request?

@rberezen
Copy link
Contributor

@anton-erofeev If you could spare a moment, your help in addressing the conflict within the pull request would be greatly appreciated. Thank you.

@filipelautert
Copy link
Collaborator

@MalloD12 could you resolve the conflicts here and then ping @rberezen ?

@MalloD12
Copy link
Collaborator

MalloD12 commented Oct 9, 2023

@MalloD12 could you resolve the conflicts here and then ping @rberezen ?

Merge conflicts resolved.

cc: @rberezen

@filipelautert filipelautert merged commit c75e308 into liquibase:master Oct 16, 2023
11 of 14 checks passed
@filipelautert filipelautert added this to the 1NEXT milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants